I added it because my browser (Firefox) was actually auto filling it, which lead to broken UX. Maybe the conditions weren't exactly the same as I was developing the feature. We should first double confirm this. IIRC, this could matter when refreshing the page.

Removing this will indeed lead to unsovable problems with Firefox. Full thread here with some recent updates. (updated)

Inputs withoutautocomplete=off attributecan lead to problems with Firefox. Full thread with details and recent updates:rails/rails#42610

But why was this not an issue on 7.1 and before?

After re-reading both Github thread and the changes from@nicolas-grekas, I’m starting to have doubts.

Hidden fields tend to encounter issues in Firefox under two scenarios.

The first is when their values or adjacent fields are manipulated via JavaScript. However, this doesn’t seem to be the case here, as the token is present in the HTML response.

The second, which I’ve recently encountered on a project and affects all browsers, involves the infamousback-forward cache (bfc or bfcache). This browser feature stores entire pages in memory for faster navigation but can cause inconsistencies if JavaScript or state changes aren’t properly handled during navigation. Notably, commonly used cache headers have no effect on its activation—onlyno-store can disable it (for now). (This reminds me, I need to open a PR about the cache attribute!)

I’m starting to think the second scenario might be more relevant in this case.

The issue happens because the JS snippet attached to the new CSRF protection changes the value of the field before submitting the form. But then, the value shouldn't be memoized on page refresh. Still, that's what FF does when the attribute is not here. I guess we can update the snippet to make it set the attribute instead, so that the generated HTML is cleaner. Or we can keep as is: strictly valid HTML isn't a requirement in itself - the web is built on being able to adapt to various levels of undefined things.

But...autocomplete attribute is interpreted during page load, no?

Does this trick work everywhere and .. why ? (genuine question .. i would not be surprise of anything with FF)

Just checked, and dynamically adding theautocomplete attribute in thecsrf_protection_controller has no effect on Firefox 133.0.3: if I submit a form and go back, the field keep the previously generated token as its value.

(BTW, it seems that setting ahiddeninputvalue property also updates itsvalue attribute 😵)

Fromhttps://developer.mozilla.org/en-US/docs/Web/Security/Practical_implementation_guides/Turning_off_form_autocompletion we can read (emphasis mine)

Settingautocomplete="off" on fields […] stops the browser from caching form data in the session history. When form data is cached in session history, the informationfilled in by the user is shown in the case where the user has submitted the form and clicked the Back button to go back to the original form page.

A user input would update thevalue property, but not thevalue attribute. As such I tried to set the attribute instead of the property in thecsrf_protection_controller, and it seems to work without anautocomplete attribute..!

- csrfField.value = csrfToken = btoa(String.fromCharCode.apply(null, (window.crypto || window.msCrypto).getRandomValues(new Uint8Array(18))));+ csrfField.setAttribute('value', csrfToken = btoa(String.fromCharCode.apply(null, (window.crypto || window.msCrypto).getRandomValues(new Uint8Array(18)))));

Note that setting thevalue attribute can be achieved by setting thedefaultValue property, so this also works:

- csrfField.value = csrfToken = btoa(String.fromCharCode.apply(null, (window.crypto || window.msCrypto).getRandomValues(new Uint8Array(18))));+ csrfField.defaultValue = csrfToken = btoa(String.fromCharCode.apply(null, (window.crypto || window.msCrypto).getRandomValues(new Uint8Array(18))));

@MatTheCat thanks for digging this topic. Can you please confirm thatsymfony/recipes#1371 would fix the issue?

Thank you@xabbuh.