Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Do not replace authenticators service by their traceable version#59278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.2fromMatTheCat:fix_traceable_authenticators
Dec 30, 2024

Conversation

MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedDec 21, 2024•
edited
Loading

QA
Branch?7.2
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#59071,fix#59091
LicenseMIT

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunate but 👍 Thanks. Hope you checked everything keeps working as expected in the profiler 😇

@MatTheCat
Copy link
ContributorAuthor

MatTheCat commentedDec 23, 2024•
edited
Loading

Hm there shouldn’t be anything unfortunate here; did I miss something? 😅

TheAuthenticatorManager will still receiveTraceableAuthenticators, the only difference is that the original authenticators will still exist in the container.

@chalasr
Copy link
Member

Just the fact we cannot stick with regular service decoration.

MatTheCat reacted with thumbs up emoji

@MatTheCatMatTheCatforce-pushed thefix_traceable_authenticators branch frome4c66eb toffbd82cCompareDecember 27, 2024 16:39
@MatTheCatMatTheCatforce-pushed thefix_traceable_authenticators branch fromc9c19ab to111913eCompareDecember 29, 2024 15:37
@fabpotfabpotforce-pushed thefix_traceable_authenticators branch from111913e tod44b7afCompareDecember 30, 2024 18:55
@fabpot
Copy link
Member

Thank you@MatTheCat.

@fabpotfabpot merged commit5280da9 intosymfony:7.2Dec 30, 2024
10 of 11 checks passed
@MatTheCatMatTheCat deleted the fix_traceable_authenticators branchDecember 30, 2024 18:57
@fabpotfabpot mentioned this pull requestDec 31, 2024
fabpot added a commit that referenced this pull requestJan 2, 2025
…security.helper` (MatTheCat)This PR was merged into the 7.2 branch.Discussion----------[SecurityBundle] Do not pass traceable authenticators to `security.helper`| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#59341| License       | MITSince#59278 authenticators are no longer aliases for their traceable version, which means calling `Security::login` with an authenticator ID won’t match its traceable ID, and fail.Plus, `Security::login` using the traceable authenticators meant the profiler could show them as successful while not supporting the request:![](https://github.com/user-attachments/assets/dc36ff28-93ba-4adf-ba16-9ed7742f3fd4)This PR fixes these issues by passing the original authenticators to `security.helper`, using their ID as name.Commits-------c5a2360 [SecurityBundle] Do not pass traceable authenticators to `security.helper`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chalasrchalasrchalasr approved these changes

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

4 participants
@MatTheCat@chalasr@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp