Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Support@> as a shorthand for!service_closure inYamlFileLoader#59257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromchx:7.3
Jan 6, 2025

Conversation

chx
Copy link
Contributor

@chxchx commentedDec 18, 2024•
edited by GromNaN
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#59255
LicenseMIT

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I appreciate the idea, but I don't like this new symbol.

  • It creates an extra way of doing the same thing.
  • It's not expressive: impossible to search for these special characters in the doc to understand what they do.
  • It looks like thesymbol@> in Postgres that is a totally different feature.

Kocal, dmaicher, chapterjason, and bcremer reacted with thumbs up emoji
@GromNaNGromNaN added Yaml and removed Bug labelsDec 18, 2024
@carsonbotcarsonbot changed the titleSupport @> as a shorthand for !service_closure in YamlFileLoader (Iss…[Yaml] Support @> as a shorthand for !service_closure in YamlFileLoader (Iss…Dec 18, 2024
@GromNaNGromNaN changed the title[Yaml] Support @> as a shorthand for !service_closure in YamlFileLoader (Iss…[Yaml] Support@> as a shorthand for!service_closure in YamlFileLoaderDec 18, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

works for me
but let's add test cases with@>?bar (and make it work)

@wouterj
Copy link
Member

I'm also not so sure if we need this shortcut. The@,@? and%...% Yaml conventions were introduced in a time where we didn't have proper tag support for Yaml. The tags are the official Yaml syntax to define custom data types (e.g. type a specific string or object). With good tag support in the Yaml component, we can use the official features instead of using our own conventions now. This remove magic and makes it easier to understand.

@nicolas-grekas
Copy link
Member

Yet I would not like to have to use!reference foo instead of@foo, so that these shortcuts are welcome IMHO.

@carsonbotcarsonbot changed the title[Yaml] Support@> as a shorthand for!service_closure in YamlFileLoader[DependencyInjection] Support@> as a shorthand for!service_closure in YamlFileLoaderDec 31, 2024
Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, if that is convenient.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I fixed the remaining comments and added a line to the changelog of the component.

GromNaN reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@chx.

@fabpotfabpot merged commita36b981 intosymfony:7.3Jan 6, 2025
11 checks passed
@OskarStarkOskarStark changed the title[DependencyInjection] Support@> as a shorthand for!service_closure in YamlFileLoader[DependencyInjection] Support@> as a shorthand for!service_closure inYamlFileLoaderJan 9, 2025
@chxchx deleted the 7.3 branchFebruary 4, 2025 02:45
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@GromNaNGromNaNGromNaN approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Support @> as a shorthand for !service_closure in YamlFileLoader
8 participants
@chx@wouterj@nicolas-grekas@fabpot@GromNaN@OskarStark@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp