Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Test] Symfony framework dagger module#59240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| #[DaggerFunction] | ||
| #[Doc('Run phpstan across the entire symfony codebase')] | ||
| // dagger call phpstan --source=. | ||
| public function phpstan(Directory $source): Container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not add a default to the right directory ?
dragoonisDec 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Neirda24 it's yin/yang .. do we really wanna phpstan the entire codebase? or just make it configurable to the caller
the best practise (Dagger best practises) isn't to hard code anything in the code, and instead just change the CLI arguments for different paths .. and that's why I've done it like this, to follow convention
let's discuss this on our next call, after I've got integration tests working..
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "name": "symfony", | |||
| "engineVersion": "v0.15.1", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what would be the process to keep this up to date ? A bot opening a PR automatically or only if its fails then we need to upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Neirda24 hey! we will manually bump this every time we want to, or need to. Since I'm from Dagger, then I'll know exactly what important stuff is being released and if it's worth the upgrade or not
…ions
As per strategic calls with@nicolas-grekas and@welcoMattic and others..
I am creating the official Dagger module for the Symfony project .. here is there initial POC.
Let's work together to ensure all flags to the respective libraries are being preserved.
there may be some different flags for local running versus inside github runners, perhaps? let's explore together 🚀