Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Always display service arguments & deprecate--show-arguments option fordebug:container#59225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Florian-Merle
Copy link
Contributor

@Florian-MerleFlorian-Merle commentedDec 16, 2024
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?yes
IssuesFix#59187
LicenseMIT

This PR does the following:

  • Always shows service arguments
  • Deprecates--show-arguments option when a service name is provided and makes it a no-op

The next step will be to remove--show-arguments in8.0.

vudaltsov reacted with thumbs up emojiAlikDex and staromand reacted with confused emojivudaltsov, chalasr, and Kocal reacted with rocket emoji
@Florian-MerleFlorian-Merleforce-pushed thedebug-container-deprecate-not-passing-show-arguments branch from0c415df to50ffbaeCompareDecember 16, 2024 14:29
@carsonbotcarsonbot added this to the7.3 milestoneDec 16, 2024
@alexislefebvre
Copy link
Contributor

Deprecate not passing the--show-arguments option when a service name is provided. The next step will be to deprecate--show-arguments in8.0.

So with Symfony 7.3 and 7.4, I would see a deprecation if I don’t use--show-arguments, that would encourage me to use this option.

Then in Symfony 8.0, using the--show-arguments option would show a deprecation message?

That sounds counter-intuitive.

@OskarStarkOskarStark changed the title[FrameworkBundle] debug:container deprecate not passing --show-arguments[FrameworkBundle] deprecate not passing--show-arguments fordebug:container commandDec 16, 2024
Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Then in Symfony 8.0, using the--show-arguments option would show a deprecation message?

I agree that it's not a great DX.
We can add the option--hide-arguments. In 8.0, change the default behavior but keep both options.

@chalasr
Copy link
Member

Or we could add--hide-arguments now in 7.3 and deprecate not setting one or the other. But do we really want to have thathide-arguments ultimately? Not sure we need it.

Asking to opt-in the behavior we want to be the only possible one, before making it the default one and removing the capacity to opt-in/out is what we usually do I think.
So apart from the fact that the option should be deprecated in 8.1 instead of 8.0, which makes a difference, the proposed plan looks good to me.

@fabpot
Copy link
Member

I would keep things simple here:

  • Always show arguments
  • Deprecate--show-arguments and make it a noop in 7.3
  • Remove--show-arguments in 8.0
GromNaN, xabbuh, chalasr, alexislefebvre, vudaltsov, and ro0NL reacted with thumbs up emoji

@GromNaN
Copy link
Member

Indeed, command output is not covered by our BC promise. If someone parses the output, they should opt for--format=json.

xabbuh and ro0NL reacted with thumbs up emoji

@chalasr
Copy link
Member

Thejson output will be impacted by this change but that’s fine for me 🙌

@fabpot
Copy link
Member

Thejson output will be impacted by this change but that’s fine for me 🙌

Not really, the only difference is that we'll always have the arguments.

ro0NL reacted with thumbs up emoji

@chalasr
Copy link
Member

Yes that’s what I mean, the output will now have anarguments key by default so a 1:1 assertion won’t pass anymore.

@Florian-MerleFlorian-Merleforce-pushed thedebug-container-deprecate-not-passing-show-arguments branch from50ffbae toc090137CompareDecember 18, 2024 13:49
@Florian-Merle
Copy link
ContributorAuthor

I updated the code to always show arguments.
Some unit tests are failing but I believe it's not because of my changes.

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm happy to see the code simplified.

chalasr and Florian-Merle reacted with thumbs up emoji
@chalasr
Copy link
Member

Please also add a note in the framework-bundle's CHANGELOG and UPGRADE-7.3 about the deprecation.

Florian-Merle reacted with thumbs up emoji

@vudaltsov

This comment was marked as off-topic.

@vudaltsov

This comment was marked as off-topic.

@chalasr

This comment was marked as off-topic.

@vudaltsov

This comment was marked as off-topic.

@Florian-Merle

This comment was marked as off-topic.

@Florian-MerleFlorian-Merleforce-pushed thedebug-container-deprecate-not-passing-show-arguments branch fromc090137 to18d47f8CompareDecember 19, 2024 12:59
@vudaltsov
Copy link
Contributor

@Florian-Merle, thank you!

Good luck with this PR, looking forward to better DX withdebug:container in 7.3!

Florian-Merle reacted with heart emoji

@Florian-MerleFlorian-Merleforce-pushed thedebug-container-deprecate-not-passing-show-arguments branch from18d47f8 to377ec8fCompareDecember 20, 2024 16:23
@chalasr
Copy link
Member

The PR title doesn't match anymore with what the PR does.

alexislefebvre, Florian-Merle, and vudaltsov reacted with thumbs up emoji

@Florian-MerleFlorian-Merle changed the title[FrameworkBundle] deprecate not passing--show-arguments fordebug:container command[FrameworkBundle] Always Display Service Arguments & Deprecate --show-arguments Option fordebug:containerDec 23, 2024
@Florian-MerleFlorian-Merle changed the title[FrameworkBundle] Always Display Service Arguments & Deprecate --show-arguments Option fordebug:container[FrameworkBundle] Always Display Service Arguments & Deprecate--show-arguments Option fordebug:containerDec 23, 2024
@nicolas-grekasnicolas-grekas changed the title[FrameworkBundle] Always Display Service Arguments & Deprecate--show-arguments Option fordebug:container[FrameworkBundle] Always display service arguments & deprecate--show-arguments option fordebug:containerJan 7, 2025
@nicolas-grekasnicolas-grekasforce-pushed thedebug-container-deprecate-not-passing-show-arguments branch from377ec8f to2641778CompareJanuary 7, 2025 14:20
@nicolas-grekas
Copy link
Member

Thank you@Florian-Merle.

@nicolas-grekasnicolas-grekas merged commitd240a6d intosymfony:7.3Jan 7, 2025
5 of 10 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@GromNaNGromNaNGromNaN left review comments

@chalasrchalasrchalasr requested changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] Enable --show-arguments in debug:container by default
8 participants
@Florian-Merle@alexislefebvre@chalasr@fabpot@GromNaN@vudaltsov@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp