Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Semaphore] Add a semaphore store based on locks#59202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alexander-schranz wants to merge14 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromalexander-schranz:feature/semphore-store-based-on-locks

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranzalexander-schranz commentedDec 12, 2024•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix #...
LicenseMIT

I really liked the idea of a semaphore component but not have the possibility to use it without Redis it did not get a lot a drive and usage in our projects and we workaround using Locks.

So this idea did come up to have a Semaphore store which can use the existing lock component for it.

@lyrixx@jderusse

Toflar reacted with heart emoji
@alexander-schranzalexander-schranz marked this pull request as ready for reviewDecember 12, 2024 18:29
@carsonbotcarsonbot added this to the7.3 milestoneDec 12, 2024
@alexander-schranzalexander-schranzforce-pushed thefeature/semphore-store-based-on-locks branch 3 times, most recently from6921d4f to38cb65bCompareDecember 12, 2024 18:50
@alexander-schranzalexander-schranzforce-pushed thefeature/semphore-store-based-on-locks branch from1fef9d7 to84e0607CompareJanuary 6, 2025 12:45
@symfonysymfony deleted a comment fromcarsonbotJan 8, 2025
@alexander-schranz
Copy link
ContributorAuthor

@jderusse if you have some free time maybe you can have a relook at the changes we did since your last review as you are I think most familiar with semaphore component.

@alexander-schranz
Copy link
ContributorAuthor

@jderusse what I'm stuck of how we can make the framework bundle integration for this.

@@ -24,7 +24,8 @@
"psr/log": "^1|^2|^3"
},
"require-dev": {
"predis/predis": "^1.1|^2.0"
"predis/predis": "^1.1|^2.0",
"symfony/lock": "^5.4 || ^6.0 || ^7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

do we really want to allow those old versions here?

Copy link
ContributorAuthor

@alexander-schranzalexander-schranzMay 26, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can change to everything the core team wants. Currently it works on this versions and I started with the 5.4 as its still supported LTS until 2029.

@Toflar
Copy link
Contributor

I really like this proposal! Is@jderusse's feedback to#59202 (comment) the only blocker?

@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@jderussejderussejderusse left review comments

@OskarStarkOskarStarkOskarStark left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

8 participants
@alexander-schranz@Toflar@nicolas-grekas@stof@jderusse@OskarStark@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp