Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] Add non-*-int missing types for PhpStanExtractor#59192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromwuchen90:fix-phpstan-non-int
Dec 18, 2024

Conversation

wuchen90
Copy link
Contributor

@wuchen90wuchen90 commentedDec 12, 2024•
edited by nicolas-grekas
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

This PR adds support for following PHPStan types in Property Info component:

  • non-positive-int
  • non-negative-int
  • non-zero-int

See PHPStan official docs for these types:https://phpstan.org/writing-php-code/phpdoc-types#integer-ranges

@fabpot
Copy link
Member

I'm going to merge it in 7.3 as this is a new feature.

mtarld reacted with thumbs up emoji

@fabpotfabpot modified the milestones:6.4,7.3Dec 16, 2024
@nicolas-grekas
Copy link
Member

@wuchen90 to match@fabpot's comment, could you please rebase on 7.3 and add a line in the changelog of the component in the 7.3 section? (to be created potentially)

@derrabusderrabus changed the base branch from6.4 to7.3December 16, 2024 10:44
@derrabus
Copy link
Member

Also, please rebase onto 7.3 and resolve the conflicts.

@xabbuhxabbuh added Feature and removed Bug labelsDec 16, 2024
@wuchen90wuchen90force-pushed thefix-phpstan-non-int branch 3 times, most recently froma08658d to82904aeCompareDecember 16, 2024 16:39
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with a minor CS change in the changelog

@fabpot
Copy link
Member

Thank you@wuchen90.

@fabpotfabpot merged commitccf91a1 intosymfony:7.3Dec 18, 2024
11 checks passed
@wuchen90wuchen90 deleted the fix-phpstan-non-int branchJanuary 20, 2025 09:32
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

@mtarldmtarldmtarld approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

8 participants
@wuchen90@fabpot@nicolas-grekas@derrabus@stof@xabbuh@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp