Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Fix compatibility to Doctrine persistence 2.5 in Doctrine Bridge 6.4 to avoid Projects stuck on 6.3#59185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranzalexander-schranz commentedDec 11, 2024•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix #...
LicenseMIT

Doctrine Bridge dropped support of persistence 2 from 6.3 to 6.4 but I could not yet find out why. (0d4e2b8). It making lot of things harder and get projects stuck on 6.3 which can not yet update doctrine/persistence because of some bc breaks (mostlyBundle:Entity syntax). It makes also eco system a little bit harder (doctrine/DoctrineBundle#1841,doctrine/DoctrineFixturesBundle#486,https://github.com/sulu/sulu/actions/runs/12050408254/job/34248387939) as with some changes in symfony and doctrine bundles things get downgraded to symfony 5.4 instead keep in 6.3. If there is any easy way to support persistence 2.5 still on 6.4 bridge I think things would get easier.

Want with this PR check what fails on the CI if still allow persistence 2.5.

Update: Looks like with a few checkst we could get lowest run on persistence 2.5 which would so make easier projects upgrade to Symfony 6.4 without they have to tackle the persistence update in the same case.

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@stof
Copy link
Member

Simply allowing 2.5 is unlikely to report actual breakages: the CI will install the highest compatible version, and so will keep installing version 3

@alexander-schranz
Copy link
ContributorAuthor

alexander-schranz commentedDec 11, 2024•
edited
Loading

@stof there isUnit Tests / Unit Tests (8.2, low-deps) which installs lowest dependency with persistence 2.5.

Bildschirmfoto 2024-12-11 um 17 56 24

Without the latest commit you see it did fail as 2.5 was installed:https://github.com/symfony/symfony/actions/runs/12280919774/job/34268515843?pr=59185

With a few line of changes I think may can catch that issue but need to invest.

@alexander-schranzalexander-schranz changed the titleFind out what breaks on Doctrine persistence 2.5Fix compatibility to Doctrine persistence 2.5 in Doctrine Bridge 6.4 to avoid Projects stuck on 6.3Dec 11, 2024
@alexander-schranzalexander-schranz marked this pull request as ready for reviewDecember 11, 2024 17:23
@carsonbotcarsonbot added this to the6.4 milestoneDec 11, 2024
@alexander-schranz
Copy link
ContributorAuthor

alexander-schranz commentedDec 11, 2024•
edited
Loading

With some version check in the tests it seems a way we could still support the persistence 2.5 version:

Bildschirmfoto 2024-12-11 um 18 25 44

Other CI errors seems be unrelated.

@carsonbotcarsonbot changed the titleFix compatibility to Doctrine persistence 2.5 in Doctrine Bridge 6.4 to avoid Projects stuck on 6.3[DoctrineBridge] Fix compatibility to Doctrine persistence 2.5 in Doctrine Bridge 6.4 to avoid Projects stuck on 6.3Dec 11, 2024
@xabbuh
Copy link
Member

ping@nicolas-grekas as you bumped the requirement in0d4e2b8

@alexander-schranz
Copy link
ContributorAuthor

Let me know if there is anything else here I should check.

@alexander-schranzalexander-schranzforce-pushed theenhancement/doctrine-persistence-2 branch from0a6a5ab tof3e5deaCompareDecember 19, 2024 08:20
@alexander-schranzalexander-schranzforce-pushed theenhancement/doctrine-persistence-2 branch fromf3e5dea toc29bcfeCompareJanuary 6, 2025 12:48
…trine Bridge 6.4 to avoid Projects stuck on 6.3
@fabpotfabpotforce-pushed theenhancement/doctrine-persistence-2 branch fromc29bcfe todf3cef8CompareJanuary 6, 2025 13:08
@fabpot
Copy link
Member

Thank you@alexander-schranz.

@fabpotfabpot merged commit02cafa9 intosymfony:6.4Jan 6, 2025
11 checks passed
@alexander-schranzalexander-schranz deleted the enhancement/doctrine-persistence-2 branchJanuary 6, 2025 13:11
@derrabus
Copy link
Member

Are we going to revert this change after merging up?

@alexander-schranz
Copy link
ContributorAuthor

Think it is fine to revert this in7.x branches.

nicolas-grekas added a commit that referenced this pull requestJan 7, 2025
…2.x (xabbuh)This PR was merged into the 7.1 branch.Discussion----------[DoctrineBridge] clean up code for doctrine/persistence 2.x| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITI missed this when merging `6.4` up after#59185Commits-------e102b89 clean up code for doctrine/persistence 2.x
This was referencedJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

8 participants
@alexander-schranz@carsonbot@stof@xabbuh@fabpot@derrabus@nicolas-grekas@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp