Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle][TwigBridge] Addis_granted_for_user() function#59129

Merged
chalasr merged 1 commit intosymfony:7.3from
natewiebe13:twig-user-is-granted
Dec 22, 2024
Merged

[SecurityBundle][TwigBridge] Addis_granted_for_user() function#59129
chalasr merged 1 commit intosymfony:7.3from
natewiebe13:twig-user-is-granted

Conversation

@natewiebe13
Copy link

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesN/A
LicenseMIT

Twig function to accompany#48142

valtzu reacted with thumbs up emoji
@natewiebe13
Copy link
Author

@derrabus hoping this can get released along with#48142 for 7.3 :)

I'll have PRs for docs ready early next week.

@OskarStarkOskarStark changed the titleAdd user_is_granted() function to twigAdduser_is_granted() function to twigDec 7, 2024
@carsonbotcarsonbot changed the titleAdduser_is_granted() function to twig[SecurityBundle][TwigBridge] Adduser_is_granted() function to twigDec 7, 2024
@OskarStarkOskarStark changed the title[SecurityBundle][TwigBridge] Adduser_is_granted() function to twig[SecurityBundle][TwigBridge] Adduser_is_granted() functionDec 7, 2024
@OskarStark
Copy link
Contributor

We also need no raise the dependency to 7.3 in composer.json to make it work

@derrabus
Copy link
Member

We also need no raise the dependency to 7.3 in composer.json to make it work

We should not need to do that. The dependency is optional. 🤔

@OskarStark
Copy link
Contributor

OskarStark commentedDec 7, 2024•
edited
Loading

We also need no raise the dependency to 7.3 in composer.json to make it work

We should not need to do that. The dependency is optional. 🤔

Ok

@natewiebe13
Copy link
Author

Fixed BC break.

@natewiebe13natewiebe13 changed the title[SecurityBundle][TwigBridge] Adduser_is_granted() function[SecurityBundle][TwigBridge] Addis_granted_for_user() functionDec 17, 2024
@stof
Copy link
Member

I'm still holding on my comment in#59129 (comment)
I don't think returnfalse for all calls tois_granted_for_user is the expected behavior if you configure the extension without a UserAuthorizationChecker.

@chalasr
Copy link
Member

Better DX is desirable here so 👍 for stof's suggestion. It should be a\LogicException

@natewiebe13
Copy link
Author

Sounds good. Just wanted to make sure there was consensus on that. 👍

@chalasr
Copy link
Member

Thank you@natewiebe13.

@chalasrchalasr merged commit78f4d9a intosymfony:7.3Dec 22, 2024
9 of 10 checks passed
@natewiebe13natewiebe13 deleted the twig-user-is-granted branchJanuary 2, 2025 15:21
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJan 3, 2025
… (Nate Wiebe)This PR was merged into the 7.3 branch.Discussion----------[Security] Add docs for `is_granted_for_user()` functionFixes#20489Adds docs for new twig function:*symfony/symfony#59129Commits-------e1c23c7 Add docs for is_granted_for_user() function
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark left review comments

@chalasrchalasrchalasr approved these changes

@xabbuhxabbuhxabbuh approved these changes

@mtarldmtarldmtarld approved these changes

@fabpotfabpotAwaiting requested review from fabpot

+1 more reviewer

@smnandresmnandresmnandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

10 participants

@natewiebe13@OskarStark@derrabus@stof@chalasr@fabpot@smnandre@xabbuh@mtarld@carsonbot
[8]ページ先頭
©2009-2026 Movatter.jp