Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Add IPv6 support toNativeHttpClient#59068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.3fromdmitrii-baranov-tg:fix_59027
Jan 2, 2025

Conversation

dmitrii-baranov-tg
Copy link
Contributor

@dmitrii-baranov-tgdmitrii-baranov-tg commentedDec 2, 2024•
edited by OskarStark
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#59027
LicenseMIT

At the moment,NativeHttpClient works only with IPv4 because of the way it does DNS resolution.
But by taking inspiration from DNS resolution inNoPrivateNetworkHttpClient, we are able to make it IPv6 compatible.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for starting this!

dmitrii-baranov-tg reacted with thumbs up emoji
@dmitrii-baranov-tg
Copy link
ContributorAuthor

Seems like theWindows / x86 / minimal-exts / lowest-php (pull_request) Workflow is flapping, I had it passing before and now it fails with just a CHANGELOG entry being changed:

image

@dmitrii-baranov-tg
Copy link
ContributorAuthor

@nicolas-grekas Shall we go ahead with the merge or something else needs to be fixed?

@fabpotfabpot modified the milestones:7.2,7.3Dec 30, 2024
@nicolas-grekas
Copy link
Member

Thank you@dmitrii-baranov-tg.

dmitrii-baranov-tg reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit04ee771 intosymfony:7.3Jan 2, 2025
11 checks passed
@OskarStarkOskarStark changed the title[HttpClient] Add IPv6 support to NativeHttpClient[HttpClient] Add IPv6 support toNativeHttpClientJan 2, 2025
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexislefebvrealexislefebvreAwaiting requested review from alexislefebvre

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Add IPv6 support to NativeHttpClient
5 participants
@dmitrii-baranov-tg@carsonbot@nicolas-grekas@alexislefebvre@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp