Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpFoundation] FixedIpUtils::anonymize exception when using IPv6 link-local addresses with RFC4007 scoping#59055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
IpUtils::anonymize exception when using IPv6 link-local addresses with RFC4007 scopingUh oh!
There was an error while loading.Please reload this page.
64d99aa to558b4f8Compare… link-local addresses with RFC4007 scoping
Thank you@jbtronics. |
558b4f8 to1696353Compare86b9250 intosymfony:6.4 1 check passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJan 29, 2025
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accessing a web server via an IPv6 link-local address, it is possible to get a
REMOTE_ADDRlikefe80::1fc4:15d8:78db:2319%enp4s0, which is then subsequently also returned by Request::getClientIp().This
%suffix is IPv6 scoping according toRFC4007, as the link-local addresses are network interface dependent, and are important to uniquely identify a device in the network.PHP and Symfony Request consider this format valid (or at least do not touch it). However, IPUtils::anonymize break when getting such a (valid) IP and throws an exception as the
inet_ntopfunction cannot handle that format and returns false.This PR fixes that by just stripping away the scoping suffix, before passing the IP to that function. I think the interface information is not important on the anonymized IP (as we want to lose the uniqueness anyway) and it might contain the interface name, which one could consider as somewhat sensitive information, that should not be leaked to end users.