NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] fix`Envelope::all()` conditional return docblock#58977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromkbond:fix/messenger-envelope-docblock-fix

Nov 26, 2024

Merged

[Messenger] fix`Envelope::all()` conditional return docblock#58977

nicolas-grekas merged 1 commit intosymfony:6.4fromkbond:fix/messenger-envelope-docblock-fix

Nov 26, 2024

Conversation

Copy link

Member

kbond commentedNov 25, 2024•
edited by nicolas-grekas
Loading

Q	A
Branch?	6.4
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	n/a
License	MIT

I think this was a typo in#47016.

[Messenger] fixEnvelope::all() conditional return docblock

e1a5beb

carsonbot added Status: Needs Review Bug Messenger labels

Nov 25, 2024

carsonbot added this to the6.4 milestone

Nov 25, 2024

kbond requested a review fromwouterj

November 25, 2024 02:05

Copy link

MemberAuthor

kbond commentedNov 25, 2024

@wouterj, sorry, I'm not familiar at all with psalm. I'm not sure how to fix the errors or what I did wrong.

Copy link

Member

wouterj commentedNov 25, 2024

@wouterj, sorry, I'm not familiar at all with psalm. I'm not sure how to fix the errors or what I did wrong.

I believe Psalm complains because we don't document anywhere that everything under$this->stamps[SomeStamp::class] is instance ofSomeStamp. I've asked on Slack if someone has a way to do this, but I think we can ignore this error. The user will not receive this error.

Copy link

MemberAuthor

kbond commentedNov 25, 2024

Ok, how can I suppress the error here?

Copy link

Member

stof commentedNov 25, 2024

@kbond you can ignore it for now.

Our usage of Psalm is a bit special as each PR reports onlynew failure (it generates a baseline for the existing state of the target branch before analyzing the code of the PR)