Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] Check if the virtual property has a setter inisAllowedProperty#58962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

pan93412
Copy link
Contributor

@pan93412pan93412 commentedNov 21, 2024•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?
IssuesFix#58556
LicenseMIT

Separate from#58960

@pan93412
Copy link
ContributorAuthor

cc@xabbuh

@pan93412pan93412force-pushed theissue-58556-property-hooks branch from3f5efa7 toe1108ecCompareNovember 25, 2024 11:32
@pan93412
Copy link
ContributorAuthor

pan93412 commentedNov 25, 2024•
edited
Loading

r?@nicolas-grekas (conflicts have been resolved)

A virtual property without setter cannot be written.
Psalm does not matter. method_exists may introduce some unneeded overhead.
@pan93412pan93412force-pushed theissue-58556-property-hooks branch frome1108ec to535b54dCompareNovember 25, 2024 11:34
@OskarStarkOskarStark changed the title [PropertyInfo] Check if the virtual property has a setter in isAllowedProperty [PropertyInfo] Check if the virtual property has a setter inisAllowedPropertyNov 25, 2024
nicolas-grekas added a commit that referenced this pull requestNov 25, 2024
…ity and Virtual Properties (xabbuh, pan93412)This PR was merged into the 5.4 branch.Discussion----------[PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#58556| License       | MIT- [ ] Rebase after#58959 and#58962 is merged.Commits-------964bf1f [PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties
@pan93412
Copy link
ContributorAuthor

Superseded by#58963.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

3 participants
@pan93412@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp