Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[PropertyInfo] consider write property visibility to decide whether a property is writable#58959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:issue-58556-asymmetric-visibilityNov 25, 2024
Merged
[PropertyInfo] consider write property visibility to decide whether a property is writable#58959
nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:issue-58556-asymmetric-visibilityNov 25, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedNov 21, 2024
Q | A |
---|---|
Branch? | 5.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Issues | part of#58556 |
License | MIT |
pan93412 suggested changesNov 21, 2024
src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
65d636b
to30f70aa
Comparesrc/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
1 task
30f70aa
to49126e1
Comparepan93412 approved these changesNov 21, 2024
alexandre-daubois approved these changesNov 22, 2024
Thank you@xabbuh. |
520e31b
intosymfony:5.4 9 of 12 checks passed
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas added a commit that referenced this pull requestNov 25, 2024
…ity and Virtual Properties (xabbuh, pan93412)This PR was merged into the 5.4 branch.Discussion----------[PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#58556| License | MIT- [ ] Rebase after#58959 and#58962 is merged.Commits-------964bf1f [PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties
This was referencedNov 27, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.