NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[DoctrineBridge] Fix`Connection::createSchemaManager()` for Doctrine DBAL v2#58956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromneodevcode:fix_doctrine_bridge_dbal_v2

Nov 25, 2024

Merged

[DoctrineBridge] Fix`Connection::createSchemaManager()` for Doctrine DBAL v2#58956

nicolas-grekas merged 1 commit intosymfony:6.4fromneodevcode:fix_doctrine_bridge_dbal_v2

Nov 25, 2024

Conversation

Copy link

Contributor

neodevcode commentedNov 20, 2024•
edited by OskarStark
Loading

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#58955
License	MIT

As the 6.4 symfony/doctrine-bridge is compatible with doctrine/dbal 2.13 we need to check for createSchemaManager existance and use getSchemaManager instead if necessary (like it's already done in the messenger component for instance)

carsonbot added Status: Needs Review Bug DoctrineBridge labels

Nov 20, 2024

carsonbot added this to the6.4 milestone

Nov 20, 2024

Copy link

carsonbot commentedNov 20, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedNov 20, 2024

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

neodevcode mentioned this pull request

Nov 20, 2024

[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine DBAL v2#58955

Closed

Copy link

Member

xabbuh commentedNov 20, 2024

Can we cover this with a test to prevent regressions?

Copy link

ContributorAuthor

neodevcode commentedNov 21, 2024

I guess I can !

OskarStark changed the title~~[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine D…~~[DoctrineBridge] FixConnection::createSchemaManager() for Doctrine DBAL v2

Nov 21, 2024

OskarStark reviewed

Nov 21, 2024

View reviewed changes

src/Symfony/Bridge/Doctrine/SchemaListener/AbstractSchemaListener.php OutdatedShow resolvedHide resolved

[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine D…

b8a8bd8

…BAL v2As the 6.4 symfony/doctrine-bridge is compatible with doctrine/dbal 2.13  we need to check for createSchemaManager existance and use getSchemaManager instead if necessary (like it's already done in the messenger component for instance)