Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Add support of millisecondes forformatTime#58946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

SebLevDev
Copy link
Contributor

@SebLevDevSebLevDev commentedNov 20, 2024
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

Description

This pull request introduces support for formatting time durations down to milliseconds in theHelper::formatTime() method. Previously, the method only supported seconds and larger units (minutes, hours, days). The new implementation adds:

  1. Support for milliseconds when the input is a fractional value (e.g., 1.456 → 1 sec, 456 ms).
  2. Accurate rounding for milliseconds.
  3. Respect for the precision parameter, limiting the number of time components displayed in the output.

Examples

Helper::formatTime(0.001);// "1 ms"Helper::formatTime(1.456);// "1 s, 456 ms"Helper::formatTime(125.789,2);// "2 min, 5 s"Helper::formatTime(172799.999,4);// "1 d, 23 h, 59 min, 59 s"Helper::formatTime(0.0005);// "< 1 ms"

jnmichielsens reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleFeature/console helper formattime ms[Console] Feature/console helper formattime msNov 20, 2024
@OskarStarkOskarStark changed the title[Console] Feature/console helper formattime ms[Console] Add support of millisecondes forformatTimeNov 20, 2024
@carsonbotcarsonbot changed the title[Console] Add support of millisecondes forformatTime[Console] Add support of millisecondes forformatTimeNov 21, 2024
@fabpot
Copy link
Member

While doing this, I would change the other units to be more in line with standard scientific notation:ms,s,min,h, andd.

@SebLevDev
Copy link
ContributorAuthor

While doing this, I would change the other units to be more in line with standard scientific notation:ms,s,min,h, andd.

Can this change not be considered a BC Break?

@fabpot
Copy link
Member

While doing this, I would change the other units to be more in line with standard scientific notation:ms,s,min,h, andd.

Can this change not be considered a BC Break?

Sure, this is pure display, so no BC promise.

@SebLevDev
Copy link
ContributorAuthor

Hello everyone,

Thank you for the feedback, especially@fabpot for the suggestion about aligning the units with standard scientific notation (ms, s, min, h, d).

I’m a bit unsure about the next steps here. Should I proceed with the proposed changes for all the units as suggested, or wait for further input from other reviewers to ensure this aligns with everyone’s expectations?

Any additional guidance or confirmation would be greatly appreciated to avoid conflicting directions.

Thanks in advance!

@fabpot
Copy link
Member

Hello everyone,

Thank you for the feedback, especially@fabpot for the suggestion about aligning the units with standard scientific notation (ms, s, min, h, d).

I’m a bit unsure about the next steps here. Should I proceed with the proposed changes for all the units as suggested, or wait for further input from other reviewers to ensure this aligns with everyone’s expectations?

Any additional guidance or confirmation would be greatly appreciated to avoid conflicting directions.

Thanks in advance!

Please, go ahead and make the suggested changes.

@fabpotfabpotforce-pushed thefeature/console_helper_formattime_ms branch from44369db toeac7d49CompareDecember 10, 2024 11:41
@fabpot
Copy link
Member

Thank you@SebLevDev.

@fabpotfabpot merged commitd1a3375 intosymfony:7.3Dec 10, 2024
6 of 7 checks passed
fabpot added a commit that referenced this pull requestDec 10, 2024
This PR was merged into the 7.3 branch.Discussion----------[Console] Fix time display in tests| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITFixes CI after#58946.Commits-------049bc63 [Console] Fix time display in tests
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@94noni94noni94noni approved these changes

@fmarchalemisysfmarchalemisysfmarchalemisys approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

6 participants
@SebLevDev@carsonbot@fabpot@94noni@fmarchalemisys@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp