Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console] Add support of millisecondes forformatTime
#58946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Console] Add support of millisecondes forformatTime
#58946
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedNov 20, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
formatTime
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
formatTime
formatTime
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
While doing this, I would change the other units to be more in line with standard scientific notation: |
Can this change not be considered a BC Break? |
Sure, this is pure display, so no BC promise. |
Hello everyone, Thank you for the feedback, especially@fabpot for the suggestion about aligning the units with standard scientific notation (ms, s, min, h, d). I’m a bit unsure about the next steps here. Should I proceed with the proposed changes for all the units as suggested, or wait for further input from other reviewers to ensure this aligns with everyone’s expectations? Any additional guidance or confirmation would be greatly appreciated to avoid conflicting directions. Thanks in advance! |
Please, go ahead and make the suggested changes. |
44369db
toeac7d49
CompareThank you@SebLevDev. |
d1a3375
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
This pull request introduces support for formatting time durations down to milliseconds in the
Helper::formatTime()
method. Previously, the method only supported seconds and larger units (minutes, hours, days). The new implementation adds:Examples