NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpKernel] Ensure`HttpCache::getTraceKey()` does not throw exception#58921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromlyrixx:SuspiciousOperationException-and-cache

Nov 20, 2024

Merged

[HttpKernel] Ensure`HttpCache::getTraceKey()` does not throw exception#58921

nicolas-grekas merged 1 commit intosymfony:5.4fromlyrixx:SuspiciousOperationException-and-cache

Nov 20, 2024

Conversation

Copy link

Member

lyrixx commentedNov 19, 2024•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	-
License	MIT

We have such logs in our logs. It's in our raw PHP logs. They are not caught by monolog, it's too early

[11-Oct-2024 01:23:33 UTC] PHP Fatal error:  Uncaught Symfony\Component\HttpFoundation\Exception\SuspiciousOperationException: Invalid method override "__CONSTRUCT". in /var/www/redirection.io/backend/blue/vendor/symfony/http-foundation/Request.php:1234Stack trace:#0 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/HttpCache/HttpCache.php(728): Symfony\Component\HttpFoundation\Request->getMethod()#1 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/HttpCache/HttpCache.php(207): Symfony\Component\HttpKernel\HttpCache\HttpCache->getTraceKey()#2 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/Kernel.php(188): Symfony\Component\HttpKernel\HttpCache\HttpCache->handle()#3 /var/www/redirection.io/backend/blue/web/app.php(9): Symfony\Component\HttpKernel\Kernel->handle()#4 {main}  thrown in /var/www/redirection.io/backend/blue/vendor/symfony/http-foundation/Request.php on line 1234

I managed to reproduced locally.

Before the patch, without the http_cache, symfony returns a 405
After the patch, without the http_cache, symfony returns a 405
Before the patch, with the http_cache, symfony returns a 500, without any information (too early)
After the patch, with the http_cache, symfony returns a 405

carsonbot added Status: Needs Review Bug HttpKernel labels

Nov 19, 2024

carsonbot added this to the5.4 milestone

Nov 19, 2024

lyrixx changed the title~~[HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception~~[HttpKernel] EnsureHttpCache::getTraceKey() does not throw exception

Nov 19, 2024

lyrixx force-pushed theSuspiciousOperationException-and-cache branch from7566856 to3e931d8Compare

November 19, 2024 09:22