Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[OptionsResolver] Allow Union/Intersection Types in Resolved Closures#58917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -232,7 +232,7 @@ public function setDefault(string $option, mixed $value): static
return $this;
}

if (isset($params[0]) &&null !==($type = $params[0]->getType()) && self::class === $type->getName() && (!isset($params[1]) || (($type = $params[1]->getType()) instanceof \ReflectionNamedType && Options::class === $type->getName()))) {
if (isset($params[0]) && ($type = $params[0]->getType()) instanceof \ReflectionNamedType && self::class === $type->getName() && (!isset($params[1]) || (($type = $params[1]->getType()) instanceof \ReflectionNamedType && Options::class === $type->getName()))) {
// Store closure for later evaluation
$this->nested[$option][] = $value;
$this->defaults[$option] = [];
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -159,6 +159,28 @@ public function testClosureWithoutParametersNotInvoked()
$this->assertSame(['foo' => $closure], $this->resolver->resolve());
}

public function testClosureWithUnionTypesNotInvoked()
{
$closure = function (int|string|null $value) {
Assert::fail('Should not be called');
};

$this->resolver->setDefault('foo', $closure);

$this->assertSame(['foo' => $closure], $this->resolver->resolve());
}

public function testClosureWithIntersectionTypesNotInvoked()
{
$closure = function (\Stringable&\JsonSerializable $value) {
Assert::fail('Should not be called');
};

$this->resolver->setDefault('foo', $closure);

$this->assertSame(['foo' => $closure], $this->resolver->resolve());
}

public function testAccessPreviousDefaultValue()
{
// defined by superclass
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp