Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DoctrineBridge] don't callEntityManager::initializeObject() with scalar values#58908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
EntityManager::initializeObject() with scalar valuesalexandre-daubois approved these changesNov 20, 2024
| @@ -104,7 +104,7 @@ public function validate($entity, Constraint $constraint) | |||
| $criteria[$fieldName] = $fieldValue; | |||
| if (null !== $criteria[$fieldName] && $class->hasAssociation($fieldName)) { | |||
| if (null !== $criteria[$fieldName] &&is_object($criteria[$fieldName]) &&$class->hasAssociation($fieldName)) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| if (null !==$criteria[$fieldName] &&is_object($criteria[$fieldName]) &&$class->hasAssociation($fieldName)) { | |
| if (\is_object($criteria[$fieldName]) &&$class->hasAssociation($fieldName)) { |
Calling initializeObject() with a scalar value (e.g. the id of theassociated entity) was a no-op call with Doctrine ORM 2 where no typewas set with the method signature. The UnitOfWork which was calledwith the given argument ignored anything that was not an InternalProxyor a PersistentCollection instance.Calls like these now break with Doctrine ORM 3 as the method's argumentis typed as object now.
Thank you@xabbuh. |
8d1ccbd to38fa83fCompare1d3d562 intosymfony:5.4 4 of 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedNov 27, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
initializeObject()with a scalar value (e.g. the id of the associated entity) was a no-op call with Doctrine ORM 2 where no type was set with the method signature. TheUnitOfWorkwhich was called with the given argument ignored anything that was not anInternalProxyor aPersistentCollectioninstance.Calls like these now break with Doctrine ORM 3 as the method's argument is typed as object now.