Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Added body size limit option to AmpHttpClient#58873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedNov 14, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Failing tests are in completely different components. My code doesn't affect those components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd rather always callsetBodySizeLimit(0)
to remove any limits, since the other clients don't have one anyway. Can you please update accordingly?
Oh, and I'd be fine fixing this on branch 5.4 as a bugfix. |
Are you sure I can change this pull request? Or should I create a new one? |
This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Removed body size limit| Q | A| ------------- | ---| Branch | 5.4| Bug fix | yes| New feature | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | Fixes Body size limit of ~10 MB in AmpHttpClient| License | MITSee#58873<!--Replace this notice by a description of your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->Commits-------122a480 Removed body size limit
This seems to cause Body Size problems with importmap:install ! PS C:\Users\flaviobb\Desktop\ProjetosContratos-pncp\contratos_symfony> composer install Run composer recipes at any time to see the status of your Symfony recipes. Executing script cache:clear [OK] Once I changed that line from Everything worked just fine!!! |
nuncanada commentedDec 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
My importmap.php:
|
Try upgrading amphp/http-client and its dependencies |
I added the option
body_size_limit
to the AmpHttpClient to be able to increase the default from AmpHttpClient, wich is ~10 MB.