Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Run tests with doctrine/data-fixtures v2#58863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

greg0ire
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?no
Issuesn/a
LicenseMIT

Symfony does not conflict with doctrine/data-fixtures v2 and is compatible with it, so let us ensure it stays that way and test v2. I also added a conflict with future v3 so that compatibility is not advertised when it is missing.

I am targeting 7.1 because 5 and 6 are not compatible with doctrine/data-fixtures v2. The incompatibility is handled in#58861.

Symfony does not conflict with doctrine/data-fixtures v2 and is compatible withit, so let us ensure it stays that way and test v2.I also added a conflict with future v3 so that compatibility is not advertisedwhen it is missing.
@carsonbotcarsonbot added this to the7.1 milestoneNov 13, 2024
@greg0ire
Copy link
ContributorAuthor

To make merges up easier, this can wait until#58861 is merged up.

@greg0iregreg0ire marked this pull request as draftNovember 13, 2024 19:04
nicolas-grekas added a commit that referenced this pull requestNov 20, 2024
…v2 (greg0ire)This PR was merged into the 5.4 branch.Discussion----------Dynamically fix compatibility with doctrine/data-fixtures v2| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues        | see explanation below| License       | MITWhile working on [allowing v2 of doctrine/data-fixtures in the bundle](doctrine/DoctrineFixturesBundle#457), I stumbled upon an issue that only affects some versions of Symfony that still have a `ContainerAwareLoader` class.The signature of `ContainerAwareLoader::addFixture()` is not compatible with the v2 signature of the `Loader` interface from `doctrine/data-fixtures`, as per this fatal error:```Declaration of Symfony\Bridge\Doctrine\DataFixtures\ContainerAwareLoader::addFixture(Doctrine\Common\DataFixtures\FixtureInterface $fixture)             must be compatible with Doctrine\Common\DataFixtures\Loader::addFixture(Doctrine\Common\DataFixtures\FixtureInterface $fixture): void```Classes that extend ContainerAwareLoader have to also extend Loader, meaning this is no breaking change because it can be argued that the incompatibility of the extending class would be with the Loader interface.Closes#58861,Closes#58863Commits-------1812aaf Dynamically fix compatibility with doctrine/data-fixtures v2
@greg0iregreg0ire deleted the test-with-data-fixtures-v2 branchNovember 20, 2024 13:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

3 participants
@greg0ire@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp