Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle] ensurevalidator.translation_domain parameter is always set#58834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedNov 12, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix#58833 |
| License | MIT |
validator.translation_domain parameter is always setkbond approved these changesNov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can confirm this fixes#58833.
OskarStark approved these changesNov 12, 2024
chalasr approved these changesNov 13, 2024
Thank you@xabbuh. |
aef53e9 intosymfony:7.2 10 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
renovatebot added a commit to Runroom/archetype-symfony that referenced this pull requestDec 15, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [symfony/debug-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/debug-bundle)) | `7.1.6`-> `7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/doctrine-messenger](https://symfony.com)([source](https://redirect.github.com/symfony/doctrine-messenger)) |`7.1.6` -> `7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/dotenv](https://symfony.com)([source](https://redirect.github.com/symfony/dotenv)) | `7.1.9` ->`7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/framework-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/framework-bundle)) |`7.1.6` -> `7.2.1` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/mailer](https://symfony.com)([source](https://redirect.github.com/symfony/mailer)) | `7.1.6` ->`7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/messenger](https://symfony.com)([source](https://redirect.github.com/symfony/messenger)) | `7.1.9` ->`7.2.1` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/phpunit-bridge](https://symfony.com)([source](https://redirect.github.com/symfony/phpunit-bridge)) | `7.1.9`-> `7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/runtime](https://symfony.com)([source](https://redirect.github.com/symfony/runtime)) | `7.1.7` ->`7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/security-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/security-bundle)) |`7.1.6` -> `7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/stopwatch](https://symfony.com)([source](https://redirect.github.com/symfony/stopwatch)) | `7.1.6` ->`7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/twig-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/twig-bundle)) | `7.1.6` ->`7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/ux-twig-component](https://symfony.com)([source](https://redirect.github.com/symfony/ux-twig-component)) |`2.21.0` -> `2.22.1` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/web-profiler-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/web-profiler-bundle)) |`7.1.9` -> `7.2.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>symfony/debug-bundle (symfony/debug-bundle)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/debug-bundle/compare/v7.1.6...v7.2.0)[CompareSource](https://redirect.github.com/symfony/debug-bundle/compare/v7.1.6...v7.2.0)</details><details><summary>symfony/doctrine-messenger(symfony/doctrine-messenger)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/doctrine-messenger/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/doctrine-messenger/compare/v7.1.6...v7.2.0)**Changelog**(symfony/doctrine-messenger@v7.2.0-RC1...v7.2.0)- no significant changes</details><details><summary>symfony/dotenv (symfony/dotenv)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/dotenv/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/dotenv/compare/v7.1.9...v7.2.0)**Changelog**(symfony/dotenv@v7.2.0-RC1...v7.2.0)- bug[symfony/symfony#59007](https://redirect.github.com/symfony/symfony/issues/59007)\[Dotenv] read runtime config from composer.json in debug dotenv command([@​xabbuh](https://redirect.github.com/xabbuh))</details><details><summary>symfony/framework-bundle (symfony/framework-bundle)</summary>###[`v7.2.1`](https://redirect.github.com/symfony/framework-bundle/releases/tag/v7.2.1)[CompareSource](https://redirect.github.com/symfony/framework-bundle/compare/v7.2.0...v7.2.1)**Changelog**(symfony/framework-bundle@v7.2.0...v7.2.1)- bug[symfony/symfony#59122](https://redirect.github.com/symfony/symfony/issues/59122)\[Notifier] fix desktop channel bus abstract arg([@​raphael-geffroy](https://redirect.github.com/raphael-geffroy))- bug[symfony/symfony#59124](https://redirect.github.com/symfony/symfony/issues/59124)\[FrameworkBundle] fix: notifier push channel bus abstract arg([@​raphael-geffroy](https://redirect.github.com/raphael-geffroy))- bug[symfony/symfony#59086](https://redirect.github.com/symfony/symfony/issues/59086)\[FrameworkBundle] Make uri_signer lazy and improve error whenkernel.secret is empty([@​nicolas-grekas](https://redirect.github.com/nicolas-grekas))###[`v7.2.0`](https://redirect.github.com/symfony/framework-bundle/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/framework-bundle/compare/v7.1.6...v7.2.0)**Changelog**(symfony/framework-bundle@v7.2.0-RC1...v7.2.0)- bug[symfony/symfony#58950](https://redirect.github.com/symfony/symfony/issues/58950)\[FrameworkBundle] Revert " Deprecate making `cache.app` adaptertaggable" (@​keulinho)- bug[symfony/symfony#58943](https://redirect.github.com/symfony/symfony/issues/58943)\[FrameworkBundle] Revert " Don't auto-register form/csrf when thecorresponding components are not installed"([@​nicolas-grekas](https://redirect.github.com/nicolas-grekas))- bug[symfony/symfony#58937](https://redirect.github.com/symfony/symfony/issues/58937)\[FrameworkBundle] Don't auto-register form/csrf when the correspondingcomponents are not installed([@​nicolas-grekas](https://redirect.github.com/nicolas-grekas))- bug[symfony/symfony#58885](https://redirect.github.com/symfony/symfony/issues/58885)\[PropertyInfo]\[Serializer]\[TypeInfo]\[Validator] TypeInfo 7.1compatibility ([@​mtarld](https://redirect.github.com/mtarld))- bug[symfony/symfony#58834](https://redirect.github.com/symfony/symfony/issues/58834)\[FrameworkBundle] ensure `validator.translation_domain` parameter isalways set (@​xabbuh)</details><details><summary>symfony/mailer (symfony/mailer)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/mailer/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/mailer/compare/v7.1.6...v7.2.0)**Changelog**(symfony/mailer@v7.2.0-RC1...v7.2.0)- bug[symfony/symfony#58888](https://redirect.github.com/symfony/symfony/issues/58888)\[Mailer]\[Notifier] Sweego is backing their bridges, thanks to them!([@​nicolas-grekas](https://redirect.github.com/nicolas-grekas))</details><details><summary>symfony/messenger (symfony/messenger)</summary>###[`v7.2.1`](https://redirect.github.com/symfony/messenger/releases/tag/v7.2.1)[CompareSource](https://redirect.github.com/symfony/messenger/compare/v7.2.0...v7.2.1)**Changelog**(symfony/messenger@v7.2.0...v7.2.1)- no significant changes###[`v7.2.0`](https://redirect.github.com/symfony/messenger/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/messenger/compare/v7.1.9...v7.2.0)**Changelog**(symfony/messenger@v7.2.0-RC1...v7.2.0)- bug[symfony/symfony#58952](https://redirect.github.com/symfony/symfony/issues/58952)\[Cache] silence warnings issued by Redis Sentinel on connection issues([@​xabbuh](https://redirect.github.com/xabbuh))- bug[symfony/symfony#58862](https://redirect.github.com/symfony/symfony/issues/58862)\[Notifier] Fix GoIpTransport([@​nicolas-grekas](https://redirect.github.com/nicolas-grekas))- bug[symfony/symfony#58818](https://redirect.github.com/symfony/symfony/issues/58818)\[Messenger] silence PHP warnings issued by `Redis::connect()`(@​xabbuh)</details><details><summary>symfony/phpunit-bridge (symfony/phpunit-bridge)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/phpunit-bridge/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/phpunit-bridge/compare/v7.1.9...v7.2.0)**Changelog**(symfony/phpunit-bridge@v7.2.0-RC1...v7.2.0)- bug[symfony/symfony#58828](https://redirect.github.com/symfony/symfony/issues/58828)\[PhpUnitBridge] fix dumping tests to skip with data providers([@​xabbuh](https://redirect.github.com/xabbuh))</details><details><summary>symfony/runtime (symfony/runtime)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/runtime/compare/v7.1.7...v7.2.0)[CompareSource](https://redirect.github.com/symfony/runtime/compare/v7.1.7...v7.2.0)</details><details><summary>symfony/security-bundle (symfony/security-bundle)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/security-bundle/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/security-bundle/compare/v7.1.6...v7.2.0)**Changelog**(symfony/security-bundle@v7.2.0-RC1...v7.2.0)- no significant changes</details><details><summary>symfony/stopwatch (symfony/stopwatch)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/stopwatch/compare/v7.1.6...v7.2.0)[CompareSource](https://redirect.github.com/symfony/stopwatch/compare/v7.1.6...v7.2.0)</details><details><summary>symfony/twig-bundle (symfony/twig-bundle)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/twig-bundle/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/twig-bundle/compare/v7.1.6...v7.2.0)**Changelog**(symfony/twig-bundle@v7.2.0-RC1...v7.2.0)- no significant changes</details><details><summary>symfony/ux-twig-component (symfony/ux-twig-component)</summary>###[`v2.22.1`](https://redirect.github.com/symfony/ux-twig-component/compare/v2.22.0...v2.22.1)[CompareSource](https://redirect.github.com/symfony/ux-twig-component/compare/v2.22.0...v2.22.1)###[`v2.22.0`](https://redirect.github.com/symfony/ux-twig-component/compare/v2.21.0...v2.22.0)[CompareSource](https://redirect.github.com/symfony/ux-twig-component/compare/v2.21.0...v2.22.0)</details><details><summary>symfony/web-profiler-bundle(symfony/web-profiler-bundle)</summary>###[`v7.2.0`](https://redirect.github.com/symfony/web-profiler-bundle/releases/tag/v7.2.0)[CompareSource](https://redirect.github.com/symfony/web-profiler-bundle/compare/v7.1.9...v7.2.0)**Changelog**(symfony/web-profiler-bundle@v7.2.0-RC1...v7.2.0)- bug[symfony/symfony#58919](https://redirect.github.com/symfony/symfony/issues/58919)\[WebProfilerBundle] Twig deprecations([@​mazodude](https://redirect.github.com/mazodude))</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick therebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[confighelp](https://redirect.github.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/Runroom/archetype-symfony).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuNTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.