Genuine curiosity questions here:

• How would this work with aliases on the controller class attribute and others on the method attribute ?
• Same question if aliases are defined on the groupe (in yaml for instance) and then on the controller ?

Are they all combined ?

Genuine curiosity questions here:

* How would this work with aliases on the controller class attribute and others on the method attribute ?* Same question if aliases are defined on the groupe (in yaml for instance) and then on the controller ?

Are they all combined ?

For now, setting aliases on non invokable controller class does nothing with it. The reason is that aliases from the attribute are added when creating the route (handled by theAttributeClassLoader::addRoute) and it needs either the __invoke method or the method where the attribute is used.

IMO, aliases should not be used on class (unless it is invokable). Setting an alias adds another name to a route and if we use alias on a class, it means that all routes declared in this class will have the same alias. But how the router will know which route should be called when we use features like$this->redirectToRoute('my_alias') ? It might be good to trigger an error if devs tries to set aliases on a class instead of on a method. What do you think ?

IMO, aliases should not be used on class (unless it is invokable). Setting an alias adds another name to a route and if we use alias on a class, it means that all routes declared in this class will have the same alias.

So no "combined aliases" (invoyable alias + name of the action route), ok!

But how the router will know which route should be called when we use features like$this->redirectToRoute('my_alias') ? It might be good to trigger an error if devs tries to set aliases on a class instead of on a method. What do you think ?

I guess it would be a better DX than not indeed :)

IMO, aliases should not be used on class (unless it is invokable). Setting an alias adds another name to a route and if we use alias on a class, it means that all routes declared in this class will have the same alias.

So no "combined aliases" (invoyable alias + name of the action route), ok!

But how the router will know which route should be called when we use features like$this->redirectToRoute('my_alias') ? It might be good to trigger an error if devs tries to set aliases on a class instead of on a method. What do you think ?

I guess it would be a better DX than not indeed :)

Done :)

Status : Needs Review

This proposal does not allow configuring the alias as deprecated (once it is a common use case for aliases)

This proposal does not allow configuring the alias as deprecated (once it is a common use case for aliases)

The attribute could accept an instance ofSymfony\Component\Routing\Alias, or maybe a subclassDeprecatedAlias with the deprecation properties set in the constructor.

This proposal does not allow configuring the alias as deprecated (once it is a common use case for aliases)

The attribute could accept an instance ofSymfony\Component\Routing\Alias, or maybe a subclassDeprecatedAlias with the deprecation properties set in the constructor.

IsSymfony\Component\Routing\Aliasreally needed ? According to thedoc, aliases can be set by string or deprecated record. So this is what I suggest :

class DeprecatedAlias {privatestring$deprecationMessage;publicfunction__construct(privatestring$aliasName,privatestring$package,privatestring$version,string$message ='Since %package% %version%: The "%aliasName%" route alias is deprecated. You should stop using it, as it will be removed in the future',    ){    }}

And in Route Attribute :

/*** @param string|string[]|DeprecatedAlias|DeprecatedAlias[]    $alias        The list of aliases for this route*/

What do you think ?

I realize my solution suggestion was incorrect as theAlias class hold the name of the route to alias, not the name of the alias itself.

namespaceSymfony\Component\Routing;useSymfony\Component\Routing\Alias;class DeprecatedAliasextends Alias{publicfunction__construct(string$id,string$package,string$version,string$message)     {parent::__construct($id);$this->setDeprecated($package,$version,$message);    }}

#[Route('/path', name:'route_name', alias:newDeprecatedAlias('legacy_alias','acme/package','10.9','Deprecation message'))]publicfunctionaction(){}

I agree agree with the class you suggest, in theSymfony\Component\Routing\Attribute namespace (even if it's not an attribute class).

The class used in the attribute should not extend the Alias class IMO (just like our Route attribute does not reuse the Route class used in the RouteCollection, allowing us to adapt the attribute API separately from the low-level API of the component)

Status: Needs Review

Thank you@damienfern.