Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [Brevo][SMS] Brevo sms notifier add options#58786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromikerib:brevo-sms-notifier
Jan 5, 2025

Conversation

ikerib
Copy link
Contributor

@ikeribikerib commentedNov 6, 2024•
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesAdded webhook, tag options to brevo notifier
LicenseMIT

I have used brevo-notifier and I realized that it was missing some options like the url address of the webhook, tags... I have added them.

I hope that I did well the pull request and everything related...

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch ">6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Notifier][Brevo][SMS] Brevo sms notifier add options[Notifier] [Brevo][SMS] Brevo sms notifier add optionsNov 6, 2024
@ikeribikerib changed the title[Notifier] [Brevo][SMS] Brevo sms notifier add options[Notifier][Brevo][SMS] Brevo sms notifier add optionsNov 6, 2024
@ikeribikerib changed the base branch from7.2 to6.4November 6, 2024 13:00
@stof
Copy link
Member

stof commentedNov 6, 2024

Adding support for new options is a new feature, not a bugfix. So this should go in the next minor version, not in 6.4.

@ikerib
Copy link
ContributorAuthor

oh! sorry!

@ikeribikerib changed the base branch from6.4 to7.2November 6, 2024 13:27
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@carsonbotcarsonbot changed the title[Notifier][Brevo][SMS] Brevo sms notifier add options[Notifier] [Brevo][SMS] Brevo sms notifier add optionsJan 5, 2025
@fabpot
Copy link
Member

Thank you@ikerib.

@fabpotfabpot merged commitae5843f intosymfony:7.3Jan 5, 2025
7 of 9 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

4 participants
@ikerib@carsonbot@stof@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp