I have just moved the command in the Twig bundle, applied most of the review suggestions (and mark them as resolved) and answered to the remaining ones.

I don't understand the psalm failure as the arrayNode method of the configuration is used elsewhere without issue. Did I miss something?

I don't understand the psalm failure as the arrayNode method of the configuration is used elsewhere without issue. Did I miss something?

I guess it can be ignored, Psalm does not know the exact type of the "rootNode" here.. and so type it as ParentNode|ArrayDefinition 🤷‍♂️

I guess it can be ignored, Psalm does not know the exact type of the "rootNode" here.. and so type it as ParentNode|ArrayDefinition 🤷‍♂️

The Psalm baseline seems to be build automatically so not sure if I have something to do on my side to "ignore" this error?

--

Meanwhile I fixed latest review comments. Is there anything I can do to move forward with PR? 🙂

Thanks

Meanwhile I fixed latest review comments. Is there anything I can do to move forward with PR? 🙂

If we use semantic configuration to configure this command, we have to add a test inhttps://github.com/symfony/symfony/blob/7.3/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/ConfigurationTest.php

FYI, we'll also have to updatehttps://github.com/symfony/symfony/blob/7.3/src/Symfony/Bundle/TwigBundle/Resources/config/schema/twig-1.0.xsd.

The Psalm baseline seems to be build automatically so not sure if I have something to do on my side to "ignore" this error?

Is it linked to a missing->end() after->prototype('integer')?

The configuration will be:

privatefunctionaddErrorDumperSection(ArrayNodeDefinition$rootNode):void    {$rootNode            ->children()                ->arrayNode('error_dumper')                    ->addDefaultsIfNotSet()                    ->children()                        ->scalarNode('path')                            ->info('The directory where error pages will be dumped.')                            ->defaultValue('%kernel.build_dir%/error_pages')                        ->end()                        ->arrayNode('status_codes')                            ->info('The error status codes to dump. By default, all 4xx and 5xx status codes will be dumped.')                            ->defaultValue([])                            ->integerPrototype()->end()                        ->end()                    ->end()                ->end()            ->end()        ;    }

Applied suggestions from@fabpot &@mtarld 👍

However, tests are now failling onSymfony\Bridge\Twig\Tests\NodeVisitor\TranslationDefaultDomainNodeVisitorTest , but I fail to see how this is related to this PR.

However, tests are now failling on Symfony\Bridge\Twig\Tests\NodeVisitor\TranslationDefaultDomainNodeVisitorTest , but I fail to see how this is related to this PR.

You can ignore it then.
Checking the 7.3 branch if it is failing there too, is a good double check and if not, a rebase should help 😃

Thank you@pyrech.