Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] fix detecting anonymous exception classes on Windows and PHP 7#58765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

xabbuh
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

such a class name can look like this:class@anonymous\x00D:\a\symfony\symfony\src\Symfony\Component\VarDumper\Tests\Caster\ExceptionCasterTest.php145D2631

@carsonbotcarsonbot added this to the5.4 milestoneNov 5, 2024
@carsonbotcarsonbot changed the title[VarDumper] fix detecting anonymous exception classes on Windows and PHP 7[VarDumper] fix detecting anonymous exception classes on Windows and PHP 7Nov 5, 2024
Copy link
Member

@alexandre-dauboisalexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would it be testable by any chance?

@xabbuh
Copy link
MemberAuthor

tests in#58721 fail without these changes

alexandre-daubois reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Looks like we use this regexp in quite a few classes:grep 'ff.*@anonymous' src/ -r

@xabbuhxabbuhforce-pushed thevar-dumper-anonymous-class-detection-windows branch from0c19e32 tof36e21dCompareNovember 5, 2024 14:17
@xabbuh
Copy link
MemberAuthor

I updated the other places the same way

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit5d5e728 intosymfony:5.4Nov 5, 2024
11 of 12 checks passed
@xabbuhxabbuh deleted the var-dumper-anonymous-class-detection-windows branchNovember 5, 2024 15:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

4 participants
@xabbuh@nicolas-grekas@alexandre-daubois@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp