Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Don't require passing the encoder name toTextPart#58764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.2fromjaviereguiluz:mime_encoder
Nov 5, 2024

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?7.2
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

While preparing this blog post:https://symfony.com/blog/new-in-symfony-7-2-mime-improvements

I realized that it's unnecessary to pass the encoder name as the first argument ofTextPart::addEncoder() because theContentEncoderInterface already requires defining agetName() method.

@javiereguiluzjaviereguiluz added this to the7.2 milestoneNov 5, 2024
@carsonbotcarsonbot changed the title[Mime] Don't require passig the encoder name to TextPart[Mime] Don't require passig the encoder name to TextPartNov 5, 2024
@OskarStarkOskarStark changed the title[Mime] Don't require passig the encoder name to TextPart[Mime] Don't require passig the encoder name toTextPartNov 5, 2024
@OskarStarkOskarStark changed the title[Mime] Don't require passig the encoder name toTextPart[Mime] Don't require passing the encoder name toTextPartNov 5, 2024
@nicolas-grekas
Copy link
Member

Thank you@javiereguiluz.

@nicolas-grekasnicolas-grekas merged commit3b5f623 intosymfony:7.2Nov 5, 2024
9 of 10 checks passed
@javiereguiluzjaviereguiluz deleted the mime_encoder branchNovember 5, 2024 10:35
@fabpotfabpot mentioned this pull requestNov 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@OskarStarkOskarStarkOskarStark left review comments

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@javiereguiluz@nicolas-grekas@stof@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp