Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Finder] Adds bsd adapter.#5876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Here are the results for the Finder tests on my Mac: |
@fabpot thank you! It seems I need to experiment a little more... |
fabpot added a commit to fabpot/symfony that referenced this pull requestOct 31, 2012
This PR was merged into the master branch.Commits-------2401274 [Finder] Added bsd adapter (need tests).Discussion----------[WIP] [Finder] Adds bsd adapter (need tests).**I have no mac or bsd system. Could someone please tell me if test pass?**I used this solution to replace `-printf` option: `find . -print0 | xargs -0 stat -f '%i '` (http://stackoverflow.com/questions/752818/why-does-macs-find-not-have-the-option-printf).Too bad Github didn't handle the file move :(The only difference between the two `find` implementation is: * GNU:https://github.com/jfsimon/symfony/pull/new/bsd_find#L2R48 * BSD:https://github.com/jfsimon/symfony/pull/new/bsd_find#L1R46
| ->ins('find') | ||
| ->add('find ') | ||
| ->arg($dir) | ||
| ->add('-noleaf') // -noleaf option is required for filesystems who doesn't follow '.' and '..' convention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
don't ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed. :)
@fabpot BSD adapter is OK on mac os x. |
fabpot added a commit that referenced this pull requestNov 1, 2012
This PR was merged into the master branch.Commits-------b550677 [Finder] Fix the BSD adapter2401274 [Finder] Added bsd adapter (need tests).Discussion----------[Finder] Adds bsd adapter.OK on mac os x.---------------------------------------------------------------------------by fabpot at 2012-10-31T08:22:05ZHere are the results for the Finder tests on my Mac:```............................................................... 63 / 181 ( 34%)......................find: -regextype: unknown primary or operatorF..............find: -regextype: unknown primary or operatorfind: -regextype: unknown primary or operator.find: -regextype: unknown primary or operatorfind: -regextype: unknown primary or operator......................... 126 / 181 ( 69%).......................................................Time: 1 second, Memory: 10.75MbThere was 1 failure:1) Symfony\Component\Finder\Tests\FinderTest::testIgnoreDotFiles with data set#1 (Symfony\Component\Finder\Adapter\PhpAdapter)Failed asserting that two arrays are equal.--- Expected+++ Actual@@ @@ Array (- 0 => '/var/folders/h7/55h7wcsx4g1cl...r/.bar'- 1 => '/var/folders/h7/55h7wcsx4g1cl...r/.foo'- 2 => '/var/folders/h7/55h7wcsx4g1cl...o/.bar'- 3 => '/var/folders/h7/55h7wcsx4g1cl...r/.git'- 4 => '/var/folders/h7/55h7wcsx4g1cl...er/foo'- 5 => '/var/folders/h7/55h7wcsx4g1cl...oo bar'- 6 => '/var/folders/h7/55h7wcsx4g1cl...ar.tmp'- 7 => '/var/folders/h7/55h7wcsx4g1cl...st.php'- 8 => '/var/folders/h7/55h7wcsx4g1cl...est.py'- 9 => '/var/folders/h7/55h7wcsx4g1cl...r/toto' ).../src/Symfony/Component/Finder/Tests/Iterator/IteratorTestCase.php:25.../src/Symfony/Component/Finder/Tests/FinderTest.php:207phpunit:46```---------------------------------------------------------------------------by jfsimon at 2012-10-31T08:46:22Z@fabpot thank you! It seems I need to experiment a little more...---------------------------------------------------------------------------by jfsimon at 2012-11-01T14:38:31Z@fabpot BSD adapter is OK on mac os x.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK on mac os x.