NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[WebProfilerBoundle] form data collector check passed and resolved options are defined#58739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromvltrof:fix_58665

Nov 4, 2024

Merged

[WebProfilerBoundle] form data collector check passed and resolved options are defined#58739

nicolas-grekas merged 1 commit intosymfony:5.4fromvltrof:fix_58665

Nov 4, 2024

Conversation

Copy link

Contributor

vltrof commentedNov 3, 2024•
edited by nicolas-grekas
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#58665
License	MIT

Greetings!
When passed or resolved value casted to false (null/false) it sets wrong value what cause exceptions described in issue. Explicit check if value defined prevent this behavior
Maybe codestyle should be fixed because of ternary

carsonbot added Status: Needs Review Bug labels

Nov 3, 2024

carsonbot added this to the6.4 milestone

Nov 3, 2024

Copy link

carsonbot commentedNov 3, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot