Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

switch from AppVeyor to GitHub Actions to run tests on Windows#58721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:gha-windows
Nov 6, 2024

Conversation

xabbuh
Copy link
Member

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
Issues
LicenseMIT

In#58370 I tried hard but failed to get our test suite running with PHPUnit 11 on AppVeyor.@wouterj did a great job reviving an old branch and got it working on GitHub Actions in#58699. I picked his commit and rebased it on the5.4 branch so that we are able to have a consistent CI config throughout all maintained branches.

smnandre, welcoMattic, and chalasr reacted with hooray emojiwelcoMattic reacted with rocket emoji
@carsonbotcarsonbot added this to the5.4 milestoneOct 30, 2024
@chadyred
Copy link
Contributor

Oh, sounds good guys 🙏 I discovered AppVeyor by searching why tests go away sometimes for no reason ^^

@OskarStark
Copy link
Contributor

You did an amazing job, thank you very much. 🖖

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

to pptimize the display in the GH UI :)

@nicolas-grekas
Copy link
Member

Thank you@wouterj and@xabbuh \o/

@nicolas-grekasnicolas-grekas merged commit2c7c4ba intosymfony:5.4Nov 6, 2024
10 of 12 checks passed
@wouterj
Copy link
Member

wouterj commentedNov 6, 2024•
edited
Loading

Wohoo! 🚀 Thanks for all the debugging work@xabbuh!

Next step I will experiment with:ForEach -Parallel to do the similar parallelization as we do in the Linux builds. Managed to get powershell running in Docker so I can properly test this locally.

nicolas-grekas and xabbuh reacted with heart emoji

@xabbuhxabbuh deleted the gha-windows branchNovember 6, 2024 14:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@wouterjwouterjwouterj left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasr

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

7 participants
@xabbuh@chadyred@OskarStark@nicolas-grekas@wouterj@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp