Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] SupportUid in#[MapQueryParameter]#58717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromseb-jean:uid-mapqueryparameter
Feb 7, 2025

Conversation

seb-jean
Copy link
Contributor

@seb-jeanseb-jean commentedOct 30, 2024•
edited by OskarStark
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#51618
LicenseMIT

I added supportUid in#[MapQueryParameter]. To use it, you must do this:

#[Route(path:'/', name:'user_show')]publicfunction indexAction(    #[MapQueryParameter] ?Ulid$groupId =null,)

@alexandre-daubois
Copy link
Member

I guess unit tests covering this new feature will be required for it to be accepted.

OskarStark reacted with thumbs up emoji

@seb-jean
Copy link
ContributorAuthor

I guess unit tests covering this new feature will be required for it to be accepted.

Ok, but I don't know how to do it :/.

@OskarStark
Copy link
Contributor

Maybe take a look at the current tests? Mostly it's a good starting point

@seb-jean
Copy link
ContributorAuthor

seb-jean commentedNov 1, 2024•
edited
Loading

The test I wrote failed becauseassertSame is used. It should beassertEquals. Do I replaceassertSame withassertEquals onthis line?

@seb-jean
Copy link
ContributorAuthor

I changed it toassertEquals and it works now.

@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@OskarStark
Copy link
Contributor

Please add a changelog entry

@seb-jean
Copy link
ContributorAuthor

Please add a changelog entry

It's done !

@fabpot
Copy link
Member

@seb-jean You need to rebase as we don't merge PRs with a merge commit.

@seb-jean
Copy link
ContributorAuthor

@seb-jean You need to rebase as we don't merge PRs with a merge commit.

I just rebased.

@seb-jean
Copy link
ContributorAuthor

Hello, are there any changes I still need to make?

@fabpot
Copy link
Member

Thank you@seb-jean.

seb-jean reacted with heart emoji

@fabpotfabpot merged commitc4ee8fd intosymfony:7.3Feb 7, 2025
6 of 7 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Work attributeMapQueryParameter withUidValueResolver
6 participants
@seb-jean@alexandre-daubois@OskarStark@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp