Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.ini#58704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 2 commits intosymfony:6.4fromZaneCEO:patch-1
Oct 30, 2024

Conversation

ZaneCEO
Copy link
Contributor

@ZaneCEOZaneCEO commentedOct 29, 2024•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58700
LicenseMIT

HttpClientDataCollector::escapePayload creates anew Process() -> it fails ifproc_open is disabled:

The Process class relies on proc_open, which is not available on your PHP installation.

#58700

@carsonbot

This comment was marked as resolved.

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update thePR base branch to target one of these branches instead? 5.4, 6.4, 7.1, 7.2.

Cheers!

Carsonbot

@xabbuhxabbuh changed the base branch from6.3 to6.4October 29, 2024 08:38
@carsonbotcarsonbot changed the titlefix for HttpClientDataCollector fails if proc_open is disabled via ph…[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via ph…Oct 29, 2024
@xabbuh
Copy link
Member

@ZaneCEO Please rebase your changes onto the6.4 branch as Symfony 6.3 is not maintained anymore.

ZaneCEO reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas added this to the6.4 milestoneOct 29, 2024
@nicolas-grekasnicolas-grekas changed the title[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via ph…[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.iniOct 29, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(we can retarget while merging)

ZaneCEO reacted with heart emoji
@nicolas-grekas
Copy link
Member

Thank you@ZaneCEO.

ZaneCEO reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit22df28a intosymfony:6.4Oct 30, 2024
8 of 10 checks passed
@ZaneCEOZaneCEO deleted the patch-1 branchOctober 30, 2024 23:04
This was referencedNov 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@ZaneCEO@carsonbot@xabbuh@nicolas-grekas@alexandre-daubois
[8]ページ先頭
©2009-2025 Movatter.jp