Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add AhaSend Bridge#58698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
farhadhf wants to merge6 commits intosymfony:7.3fromAhaSend:mailer-ahasend
Closed

Conversation

farhadhf
Copy link
Contributor

@farhadhffarhadhf commentedOct 28, 2024
edited by OskarStark
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT
Doc PRsymfony/symfony-docs#20361
Recipe PRsymfony/recipes#1350

This PR adds support for a new mail bridge for theAhaSend email service.
It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@farhadhffarhadhf changed the titleAdd AhaSend Mailer Bridge[Mailer] Add AhaSend BridgeOct 28, 2024
];
}

public function testSend()
Copy link
Contributor

@OskarStarkOskarStarkNov 26, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please use MockHttpClient (no mock) with a JsonMockResponse (also no mock)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've made some changes (followed what the Postal mailer bridge is doing). Please let me know if it looks good.

@farhadhf
Copy link
ContributorAuthor

The requested changes have been made, I'd appreciate another review@OskarStark .

@carsonbotcarsonbot changed the title[Mailer] Add AhaSend BridgeAdd AhaSend BridgeJan 5, 2025
@fabpot
Copy link
Member

Thank you@farhadhf.

fabpot added a commit that referenced this pull requestJan 5, 2025
This PR was squashed before being merged into the 7.3 branch.Discussion----------[Mailer] Add AhaSend Bridge| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Issues        || License       | MIT| Doc PR |symfony/symfony-docs#20361| Recipe PR |symfony/recipes#1350This PR adds support for a new mail bridge for the [AhaSend](https://ahasend.com) email service.It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.Commits-------3dfad14 [Mailer] Add AhaSend Bridge
@fabpotfabpot closed thisJan 5, 2025
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

4 participants
@farhadhf@carsonbot@fabpot@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp