Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Add AhaSend Bridge#58698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add AhaSend Bridge#58698
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedOct 28, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedOct 28, 2024
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
src/Symfony/Bundle/FrameworkBundle/Resources/config/mailer_webhook.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/AhaSend/RemoteEvent/AhaSendPayloadConverter.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
]; | ||
} | ||
public function testSend() |
OskarStarkNov 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please use MockHttpClient (no mock) with a JsonMockResponse (also no mock)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've made some changes (followed what the Postal mailer bridge is doing). Please let me know if it looks good.
src/Symfony/Component/Mailer/Bridge/AhaSend/Tests/Transport/AhaSendApiTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/AhaSend/Transport/AhaSendApiTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/AhaSend/Transport/AhaSendTransportFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/AhaSend/Webhook/AhaSendRequestParser.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/AhaSend/Webhook/AhaSendRequestParser.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The requested changes have been made, I'd appreciate another review@OskarStark . |
Thank you@farhadhf. |
This PR was squashed before being merged into the 7.3 branch.Discussion----------[Mailer] Add AhaSend Bridge| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues || License | MIT| Doc PR |symfony/symfony-docs#20361| Recipe PR |symfony/recipes#1350This PR adds support for a new mail bridge for the [AhaSend](https://ahasend.com) email service.It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.Commits-------3dfad14 [Mailer] Add AhaSend Bridge
Uh oh!
There was an error while loading.Please reload this page.
This PR adds support for a new mail bridge for theAhaSend email service.
It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.