Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] Initialize RedisAdapter cursor to 0#58661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromthomas-hiron:7.1
Oct 25, 2024

Conversation

@thomas-hiron
Copy link
Contributor

@thomas-hironthomas-hiron commentedOct 25, 2024
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58660
LicenseMIT

See#58660 for details and reproducer.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekas modified the milestones:7.1,5.4Oct 25, 2024
@nicolas-grekas
Copy link
Member

Thank you@thomas-hiron.

@nicolas-grekasnicolas-grekas merged commit61b8de4 intosymfony:5.4Oct 25, 2024
6 of 11 checks passed
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull requestOct 25, 2024
… (thomas-hiron)"This reverts commit61b8de4, reversingchanges made toee6d61b.
nicolas-grekas added a commit that referenced this pull requestOct 25, 2024
…las-grekas)This PR was merged into the 5.4 branch.Discussion----------[Cache] Revert "Initialize RedisAdapter cursor to 0"| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITI missed integration tests being red, and#58661 is the most likely cause./cc `@thomas`-hironCommits-------3c0d75f Revert "bug#58661 [Cache] Initialize RedisAdapter cursor to 0 (thomas-hiron)"
nicolas-grekas added a commit that referenced this pull requestOct 25, 2024
* 5.4:  Revert "bug#58661 [Cache] Initialize RedisAdapter cursor to 0 (thomas-hiron)"
nicolas-grekas added a commit that referenced this pull requestOct 25, 2024
* 6.4:  Revert "bug#58661 [Cache] Initialize RedisAdapter cursor to 0 (thomas-hiron)"
nicolas-grekas added a commit that referenced this pull requestOct 25, 2024
* 7.1:  Revert "bug#58661 [Cache] Initialize RedisAdapter cursor to 0 (thomas-hiron)"
This was referencedOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@thomas-hiron@carsonbot@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp