If a message fails, it will be redispatched to the configured failure transport. Until now, this could only happen once, as each envelope could only have oneSentToFailureTransportStamp. This limitation got removed, allowing an envelope to fail and be redispatched to the failure transport multiple times. To prevent endless dispatch loops, an envelope does not get redispatched if it had already been dispatched to the same transport.

Let's say we have the following transports:

framework:messenger:transports:transport_1:dsn:'null://'failure_transport:transport_2transport_2:dsn:'null://'failure_transport:failure_transport_1failure_transport_1:'null://'

A message dispatched totransport_1 would fail and be redispatched totransport_2. If it fails again intransport_2 (after the configured retry strategy etc.), it would then be redispatched tofailure_transport_1.

All "intermediate" failure transports (i.e. those that a have failure transport themselves) do not get tagged as failure transports. This way they will now show up in themessenger:failed:* commands.

carsonbot added Status: Needs Review Feature Messenger labels

Oct 24, 2024

carsonbot added this to the7.2 milestone

Oct 24, 2024

Copy link

carsonbot commentedOct 24, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

Contributor

valtzu commentedOct 25, 2024

This would be very useful when using a transport which gets messages from outside the app ("readonly transport") where you can't push any retries to the original transport.

For example this 👇 and then have consumers onevents &retry.

framework:messenger:transports:events:dsn:'kafka://'retry_strategy:max_retries:0failure_transport:retryretry:dsn:'doctrine://?queue=retry'failure_transport:failedfailed:'doctrine://?queue=failed'

Ocarthon force-pushed thefeat/messenger-failure-chain branch from6a73ecf to3ed488cCompare

October 28, 2024 07:32

Ocarthon force-pushed thefeat/messenger-failure-chain branch from3ed488c to7a374beCompare

November 7, 2024 07:54

fabpot modified the milestones:7.2,7.3

Nov 20, 2024

Ocarthon force-pushed thefeat/messenger-failure-chain branch from7a374be to90e25c9Compare

December 9, 2024 14:12

Ocarthon changed the title~~[Messenger] Allow chaining multiple failure transports~~[Messenger][FrameworkBundle] Allow chaining multiple failure transports

Dec 13, 2024

Ocarthon force-pushed thefeat/messenger-failure-chain branch from90e25c9 to0a0cb5aCompare

January 30, 2025 08:09