Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] ensure compatibility with Twig 3.15#58649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:twig-4398
Oct 25, 2024

Conversation

xabbuh
Copy link
Member

@xabbuhxabbuh commentedOct 23, 2024•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

take the changes fromtwigphp/Twig#4398 into account

@carsonbotcarsonbot added this to the5.4 milestoneOct 23, 2024
@xabbuhxabbuh changed the title[TwigBridge] fix test compatibility with Twig 3.15[TwigBridge] ensure compatibility with Twig 3.15Oct 23, 2024
@xabbuhxabbuhforce-pushed thetwig-4398 branch 2 times, most recently fromdd8f24f toa2decdbCompareOctober 24, 2024 06:27
@xabbuhxabbuh requested a review fromfabpotOctober 24, 2024 06:33
@@ -51,8 +53,8 @@ public function enterNode(Node $node, Environment $env): Node
return $node;
} else {
$var = $this->getVarName();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just discovered that this node visitor breaks reproducible compilation here.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good point, let's fix this explicitly in a separate PR

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just noticed that this was fixed for 7.2 in#57609. Should we backport that PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

that PR is actually broken

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

let's backport (and fix the broken part) in 5.4 yes
reproducible builds FTW

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A way to generate a reproducible name that does not clash with parent or child template could be to use a hash of the template name in the variable name (with the new hardcoded name as prefix)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@xabbuhxabbuhforce-pushed thetwig-4398 branch 2 times, most recently from54684fa tofd70afdCompareOctober 24, 2024 11:30
@xabbuh
Copy link
MemberAuthor

I updated theDumpNode class to also accept aLocalVariable instance.

Though I am stuck at how we can deal with a similar case in theStopwatchNode. Any idea how to handle it?

@xabbuh
Copy link
MemberAuthor

xabbuh commentedOct 24, 2024•
edited
Loading

I think I got a solution for theStopwatchNode as well.

Status: Needs Review

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commitc05fed1 intosymfony:5.4Oct 25, 2024
10 of 12 checks passed
@xabbuhxabbuh deleted the twig-4398 branchOctober 25, 2024 15:20
This was referencedOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@fabpotfabpotAwaiting requested review from fabpot

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

4 participants
@xabbuh@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp