Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Use ComposerInstalledVersions to check if flex is installed#58643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

andyexeter
Copy link
Contributor

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58624
LicenseMIT

As discussed in#58624, this fixes a class not found error which is thrown when security bundle config is missing.

@andyexeter
Copy link
ContributorAuthor

Appveyor build failure appears unrelated

@stof
Copy link
Member

In other places, we perform theclass_exists check on theRecipe class of flex (which has no extra dependency through a parent class) to detect the fact that Flex is installed.

@andyexeter
Copy link
ContributorAuthor

In other places, we perform theclass_exists check on theRecipe class of flex (which has no extra dependency through a parent class) to detect the fact that Flex is installed.

@stof could you point me in the direction of where that is done? I can't find any reference to theRecipe class in the Symfony monorepo.

@nicolas-grekas is anything blocking this being merged?

@nicolas-grekasnicolas-grekas modified the milestones:7.1,7.2Feb 4, 2025
@OskarStarkOskarStark changed the title[SecurityBundle] Use Composer InstalledVersions to check if flex is installed[SecurityBundle] Use ComposerInstalledVersions to check if flex is installedApr 9, 2025
@fabpotfabpot changed the base branch from7.1 to7.2May 10, 2025 09:56
@fabpotfabpotforce-pushed the58624-security-bundle-composer-installed-versions branch from74a5f3d to5f8eb21CompareMay 10, 2025 09:56
@fabpot
Copy link
Member

Thank you@andyexeter.

@fabpotfabpot merged commitd0ce2d6 intosymfony:7.2May 10, 2025
9 of 11 checks passed
@fabpotfabpot mentioned this pull requestMay 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@SpomkySpomkySpomky approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

7 participants
@andyexeter@stof@fabpot@nicolas-grekas@OskarStark@Spomky@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp