NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[DependencyInjection] Fix parsing nested AutowireInline attributes#58631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.1fromnicolas-grekas:di-autowire-inline

Oct 22, 2024

Merged

[DependencyInjection] Fix parsing nested AutowireInline attributes#58631

nicolas-grekas merged 1 commit intosymfony:7.1fromnicolas-grekas:di-autowire-inline

Oct 22, 2024

Conversation

Copy link

Member

nicolas-grekas commentedOct 22, 2024

Q	A
Branch?	7.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	-
License	MIT

A service definition like the following is supposed to work, yet we missed parsing it correctly. This fixes it.

publicfunction__construct(        #[AutowireInline(            MarkdownConverter::class,            [newAutowireInline(                    Environment::class,                    calls: [                        ['addExtension', [newAutowireInline(CommonMarkCoreExtension::class)]],                        ['addExtension', [newAutowireInline(AutolinkExtension::class)]],                    ],                )            ]        )]privateConverterInterface$markdownConverter,    ) {    }