Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minor fixes aroundparse_url() checks#58627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:parse-url
Oct 22, 2024

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

Those are all minor but some can still lead to edge-case bugs.

@carsonbotcarsonbot added this to the5.4 milestoneOct 22, 2024
@OskarStarkOskarStark changed the titleMinor fixes around parse_url() checksMinor fixes aroundparse_url() checksOct 22, 2024
@nicolas-grekasnicolas-grekas merged commitaf21e7e intosymfony:5.4Oct 22, 2024
9 of 12 checks passed
@nicolas-grekasnicolas-grekas deleted the parse-url branchOctober 24, 2024 14:18
This was referencedOct 27, 2024
github-merge-queuebot pushed a commit to Lendable/composer-license-checker that referenced this pull requestOct 30, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [phpstan/phpstan](https://redirect.github.com/phpstan/phpstan) |`1.12.6` -> `1.12.7` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/phpstan%2fphpstan/1.12.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpstan%2fphpstan/1.12.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpstan%2fphpstan/1.12.6/1.12.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpstan%2fphpstan/1.12.6/1.12.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)|| [phpunit/phpunit](https://phpunit.de/)([source](https://redirect.github.com/sebastianbergmann/phpunit)) |`11.4.1` -> `11.4.3` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/phpunit%2fphpunit/11.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpunit%2fphpunit/11.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpunit%2fphpunit/11.4.1/11.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpunit%2fphpunit/11.4.1/11.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)|| [rector/rector](https://getrector.org)([source](https://redirect.github.com/rectorphp/rector)) | `1.2.6` ->`1.2.8` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/rector%2frector/1.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/rector%2frector/1.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/rector%2frector/1.2.6/1.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/rector%2frector/1.2.6/1.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|| [symfony/filesystem](https://symfony.com)([source](https://redirect.github.com/symfony/filesystem)) | `6.4.12` ->`6.4.13` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2ffilesystem/6.4.13?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2ffilesystem/6.4.13?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2ffilesystem/6.4.12/6.4.13?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2ffilesystem/6.4.12/6.4.13?slim=true)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>phpstan/phpstan (phpstan/phpstan)</summary>###[`v1.12.7`](https://redirect.github.com/phpstan/phpstan/releases/tag/1.12.7)[CompareSource](https://redirect.github.com/phpstan/phpstan/compare/1.12.6...1.12.7)# Major new features 🚀- **Implement template default types**([#&#8203;3457](https://redirect.github.com/phpstan/phpstan-src/pull/3457)),[#&#8203;4801](https://redirect.github.com/phpstan/phpstan/issues/4801),thanks [@&#8203;jiripudil](https://redirect.github.com/jiripudil)!    -   Seehttps://x.com/OndrejMirtes/status/1843920480342057154# Improvements 🔧- Move result cache output from debug (`-vvv`) to very verbose (`-vv`)mode([#&#8203;3345](https://redirect.github.com/phpstan/phpstan-src/pull/3345)),thanks [@&#8203;janedbal](https://redirect.github.com/janedbal)!- Support for `non-empty-array` and `non-empty-list` array shape kind(phpstan/phpstan-src@107a7e3)- Improve lowercase string verbosity level([#&#8203;3567](https://redirect.github.com/phpstan/phpstan-src/pull/3567)),thanks[@&#8203;VincentLanglet](https://redirect.github.com/VincentLanglet)!- Show TypeResult reasons in StrictComparisonOfDifferentTypesRule(phpstan/phpstan-src@34bacd7)- Decorate reasons when comparing ConstantArrayType(phpstan/phpstan-src@dc5d8f4),[#&#8203;11799](https://redirect.github.com/phpstan/phpstan/issues/11799),[#&#8203;10421](https://redirect.github.com/phpstan/phpstan/issues/10421)# Bugfixes 🐛- Fix nextAutoIndexes in array coming fromArrayCombineFunctionReturnTypeExtension(phpstan/phpstan-src@c4ba434),[#&#8203;11819](https://redirect.github.com/phpstan/phpstan/issues/11819)- Fix return type of `array_reverse()` with optional keys([#&#8203;3406](https://redirect.github.com/phpstan/phpstan-src/pull/3406)),[#&#8203;11549](https://redirect.github.com/phpstan/phpstan/issues/11549),thanks [@&#8203;herndlm](https://redirect.github.com/herndlm)!- Try to quit the child process only after internal errors wereaccounted for(phpstan/phpstan-src@dcd69eb),[#&#8203;11826](https://redirect.github.com/phpstan/phpstan/issues/11826)- react/http PHP 8.4 patch(phpstan/phpstan-src@40e461d)# Function signature fixes 🤖- functionMap: more precise `get_defined_vars()`([#&#8203;3546](https://redirect.github.com/phpstan/phpstan-src/pull/3546)),thanks [@&#8203;janedbal](https://redirect.github.com/janedbal)!- Reflection `getAttributes` returns `list`([#&#8203;3548](https://redirect.github.com/phpstan/phpstan-src/pull/3548)),thanks [@&#8203;ManuelHu](https://redirect.github.com/ManuelHu)!- More precise md5/sha1 return type([#&#8203;3541](https://redirect.github.com/phpstan/phpstan-src/pull/3541)),thanks [@&#8203;staabm](https://redirect.github.com/staabm)!- Improve return type of token_name() and PhpToken::getTokenName()([#&#8203;3558](https://redirect.github.com/phpstan/phpstan-src/pull/3558)),[#&#8203;11808](https://redirect.github.com/phpstan/phpstan/issues/11808),thanks [@&#8203;zonuexe](https://redirect.github.com/zonuexe)!# Internals 🔍- Fix typo(phpstan/phpstan-src@5b43d50)- Introduce isSuperTypeOfWithReason([#&#8203;3538](https://redirect.github.com/phpstan/phpstan-src/pull/3538)),thanks[@&#8203;VincentLanglet](https://redirect.github.com/VincentLanglet)!- Add function `PHPStan\dumpPhpDocType()`([#&#8203;3559](https://redirect.github.com/phpstan/phpstan-src/pull/3559)),[#&#8203;11561](https://redirect.github.com/phpstan/phpstan/issues/11561),thanks [@&#8203;zonuexe](https://redirect.github.com/zonuexe)!- Introduce TypeResult(phpstan/phpstan-src@a815d57)</details><details><summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary>###[`v11.4.3`](https://redirect.github.com/sebastianbergmann/phpunit/releases/tag/11.4.3):PHPUnit 11.4.3[CompareSource](https://redirect.github.com/sebastianbergmann/phpunit/compare/11.4.2...11.4.3)##### Changed-[#&#8203;6010](https://redirect.github.com/sebastianbergmann/phpunit/pull/6010):Improve parameter name for `assertGreaterThan()`,`assertGreaterThanOrEqual()`, `assertLessThan()`, and`assertLessThanOrEqual()`-[#&#8203;6012](https://redirect.github.com/sebastianbergmann/phpunit/pull/6012):Remove empty lines between TeamCity events##### Fixed-[#&#8203;6017](https://redirect.github.com/sebastianbergmann/phpunit/pull/6017):Deprecation Triggers are not registered when Process Isolation is used***[How to install or updatePHPUnit](https://docs.phpunit.de/en/11.4/installation.html)###[`v11.4.2`](https://redirect.github.com/sebastianbergmann/phpunit/releases/tag/11.4.2):PHPUnit 11.4.2[CompareSource](https://redirect.github.com/sebastianbergmann/phpunit/compare/11.4.1...11.4.2)##### Changed-[#&#8203;5989](https://redirect.github.com/sebastianbergmann/phpunit/pull/5989):Disable Xdebug in subprocesses when it is not used##### Fixed-[#&#8203;5844](https://redirect.github.com/sebastianbergmann/phpunit/issues/5844):Error handlers that are not callable outside the scope they wereregistered in are not handled correctly-[#&#8203;5982](https://redirect.github.com/sebastianbergmann/phpunit/pull/5982):Typo in exception message***[How to install or updatePHPUnit](https://docs.phpunit.de/en/11.4/installation.html)</details><details><summary>rectorphp/rector (rector/rector)</summary>###[`v1.2.8`](https://redirect.github.com/rectorphp/rector/releases/tag/1.2.8):Released Rector 1.2.8[CompareSource](https://redirect.github.com/rectorphp/rector/compare/1.2.7...1.2.8)#### Bugfixes 🐛- \[UnusedImport] Fix removing multiple uses([#&#8203;6376](https://redirect.github.com/rectorphp/rector-src/pull/6376)),Thanks [@&#8203;jorgsowa](https://redirect.github.com/jorgsowa)!- \[PostRector] Clean up variables and conditional usage onUnusedImportRemovingPostRector([#&#8203;6378](https://redirect.github.com/rectorphp/rector-src/pull/6378))- \[PostRector] Reduce repetitive toString() on loop onUnusedImportRemovingPostRector([#&#8203;6379](https://redirect.github.com/rectorphp/rector-src/pull/6379))- \[CodeQuality] Skip no @&#8203; property doc onDynamicDocBlockPropertyToNativePropertyRector([#&#8203;6380](https://redirect.github.com/rectorphp/rector-src/pull/6380))- \[CodeQuality] Handle with other attributes onDynamicDocBlockPropertyToNativePropertyRector([#&#8203;6381](https://redirect.github.com/rectorphp/rector-src/pull/6381))- \[CodeQuality] Use existing PhpAttributeAnalyzer service instead ofAttributeFinder from Doctrine package onDynamicDocBlockPropertyToNativePropertyRector([#&#8203;6382](https://redirect.github.com/rectorphp/rector-src/pull/6382))- Fix duplicated register ContinueToBreakInSwitchRector in php52.php andphp73.php([#&#8203;6385](https://redirect.github.com/rectorphp/rector-src/pull/6385))- \[AutoImport] Fix missing @&#8203; in deep annotation auto import([#&#8203;6386](https://redirect.github.com/rectorphp/rector-src/pull/6386))- \[DeadCode] Skip non FullyQualified property type onRemoveTypedPropertyNonMockDocblockRector([#&#8203;6383](https://redirect.github.com/rectorphp/rector-src/pull/6383))<br>#### New Features 🥳- \[CodeQuality] Add DynamicDocBlockPropertyToNativePropertyRector([#&#8203;5691](https://redirect.github.com/rectorphp/rector-src/pull/5691))- \[DX] \[Experimental] Add withPhpLevel() to raise PHP level one ruleat a time([#&#8203;6261](https://redirect.github.com/rectorphp/rector-src/pull/6261))###[`v1.2.7`](https://redirect.github.com/rectorphp/rector/releases/tag/1.2.7):Released Rector 1.2.7[CompareSource](https://redirect.github.com/rectorphp/rector/compare/1.2.6...1.2.7)#### New Features 🥳- Apply AddOverrideAttributeToOverriddenMethodsRector to traits([#&#8203;6367](https://redirect.github.com/rectorphp/rector-src/pull/6367)),Thanks [@&#8203;jrjohnson](https://redirect.github.com/jrjohnson)!- \[Transform] MethodCall to New([#&#8203;6352](https://redirect.github.com/rectorphp/rector-src/pull/6352)),Thanks [@&#8203;peterfox](https://redirect.github.com/peterfox)!- Add RemoveTypedPropertyNonMockDocblockRector([#&#8203;6306](https://redirect.github.com/rectorphp/rector-src/pull/6306))- \[DX] Add links to open the editor to the names of processed files andthe names of rules applied([#&#8203;6272](https://redirect.github.com/rectorphp/rector-src/pull/6272)),Thanks[@&#8203;carlos-granados](https://redirect.github.com/carlos-granados)!<br>#### Bugfixes 🐛- Fixed --memory-limit=-1 option handling when used in parallel([#&#8203;6349](https://redirect.github.com/rectorphp/rector-src/pull/6349)),Thanks [@&#8203;ddegasperi](https://redirect.github.com/ddegasperi)!- \[Php70] Fix delimiter in the middle on EregToPregMatchRector([#&#8203;6356](https://redirect.github.com/rectorphp/rector-src/pull/6356))- \[Php70] More delimiter case in the middle fix onEregToPregMatchRector([#&#8203;6357](https://redirect.github.com/rectorphp/rector-src/pull/6357))- \[Php80] Cast string/int for int vs string condition and casecondition on ChangeSwitchToMatchRector([#&#8203;6359](https://redirect.github.com/rectorphp/rector-src/pull/6359))- \[DeadCode] Skip from call with return docblock onReduceAlwaysFalseIfOrRector([#&#8203;6361](https://redirect.github.com/rectorphp/rector-src/pull/6361))- \[TypeDeclaration] Closure Param Types from Iterator Source([#&#8203;6345](https://redirect.github.com/rectorphp/rector-src/pull/6345)),Thanks [@&#8203;peterfox](https://redirect.github.com/peterfox)!- \[Privatization] Allow privatize protected promoted property onPrivatizeFinalClassPropertyRector([#&#8203;6360](https://redirect.github.com/rectorphp/rector-src/pull/6360))- \[DeadCode] Skip with Else and ElseIf on SimplifyIfNotNullReturnRector([#&#8203;6365](https://redirect.github.com/rectorphp/rector-src/pull/6365))- \[Php70] Handle empty branch crash on unprintable char \x0C onEregToPregMatchRector([#&#8203;6368](https://redirect.github.com/rectorphp/rector-src/pull/6368))- \[UnusedImport] Different letter case for classes + optimization([#&#8203;6362](https://redirect.github.com/rectorphp/rector-src/pull/6362)),Thanks [@&#8203;jorgsowa](https://redirect.github.com/jorgsowa)!- \[CodeQuality] Skip else indirect return on SimplifyIfReturnBoolRector([#&#8203;6371](https://redirect.github.com/rectorphp/rector-src/pull/6371))- \[CodeQuality] Clean up else check on SimplifyIfReturnBoolRector([#&#8203;6372](https://redirect.github.com/rectorphp/rector-src/pull/6372))- \[TypeDeclaration] Fix deep nested array docblock with \ prefix onReturnTypeFromStrictNewArrayRector([#&#8203;6373](https://redirect.github.com/rectorphp/rector-src/pull/6373))- \[EarlyReturn] Skip nested with OR in root if statement condition onChangeNestedForeachIfsToEarlyContinueRector([#&#8203;6375](https://redirect.github.com/rectorphp/rector-src/pull/6375))- \[DeadCode] Skip RemoveUnusedPrivatePropertyRector in middle assign([#&#8203;6363](https://redirect.github.com/rectorphp/rector-src/pull/6363))<br>#### Removed 💀- \[NodeAnalyzer] Remove ClassAnalyzer::isAnonymousClassName()([#&#8203;6351](https://redirect.github.com/rectorphp/rector-src/pull/6351))- \[NodeAnalyzer] Remove unused AstResolver on VariadicAnalyzer([#&#8203;6353](https://redirect.github.com/rectorphp/rector-src/pull/6353))- \[DeadCode] Clean up double private method filtering onRemoveUnusedPrivateMethodRector([#&#8203;6364](https://redirect.github.com/rectorphp/rector-src/pull/6364))- \[DeadCode] Skip union docblock param with is_object() native typecheck on RemoveAlwaysTrueIfConditionRector([#&#8203;6370](https://redirect.github.com/rectorphp/rector-src/pull/6370))<br>***<br>#### rectorphp/rector-symfony 🎵 - \[CodeQuality] Add AddTraitGetterReturnTypeBasedOnSetterRequiredRector([#&#8203;671](https://redirect.github.com/rectorphp/rector-symfony/pull/671))<br>#### rectorphp/rector-phpunit 🟢 - \[PHPUnit 10] Add ifs as default way for withConsecutive, as morereadable and opens upgrade during PHPUnit 9([#&#8203;382](https://redirect.github.com/rectorphp/rector-phpunit/pull/382))- Use simple direct assert on consecutive in case of arrow function incallable([#&#8203;381](https://redirect.github.com/rectorphp/rector-phpunit/pull/381))- Use more readable ifs on will return in WithConsecutiveRector([#&#8203;380](https://redirect.github.com/rectorphp/rector-phpunit/pull/380))- add NarrowSingleWillReturnCallbackRector to code quality set([#&#8203;379](https://redirect.github.com/rectorphp/rector-phpunit/pull/379))</details><details><summary>symfony/filesystem (symfony/filesystem)</summary>###[`v6.4.13`](https://redirect.github.com/symfony/filesystem/releases/tag/v6.4.13)[CompareSource](https://redirect.github.com/symfony/filesystem/compare/v6.4.12...v6.4.13)**Changelog**(symfony/filesystem@v6.4.12...v6.4.13)- bug[symfony/symfony#58627](https://redirect.github.com/symfony/symfony/issues/58627)Minor fixes around `parse_url()` checks (@&#8203;nicolas-grekas)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[confighelp](https://redirect.github.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/Lendable/composer-license-checker).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEzMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@xabbuh@alexandre-daubois@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp