Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation][Lock] Ensure compatibility with ext-mongodb v2#58619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromGromNaN:mongodb-v2
Oct 22, 2024

Conversation

@GromNaN
Copy link
Member

@GromNaNGromNaN commentedOct 21, 2024•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

The extensionmongodb and the librarymongodb/mongodb will soon have a version 2.0 that brings breaking changes (seeextension changes andlibrary changes). This PR ensures compatibility with the upcoming version for Symfony 5.4.

@carsonbot

This comment was marked as outdated.

@carsonbotcarsonbot changed the titleEnsure compatibility with mongodb v2[HttpFoundation][Lock] Ensure compatibility with mongodb v2Oct 21, 2024
@GromNaNGromNaN marked this pull request as ready for reviewOctober 21, 2024 20:14
@carsonbotcarsonbot added this to the5.4 milestoneOct 21, 2024
@GromNaNGromNaN changed the title[HttpFoundation][Lock] Ensure compatibility with mongodb v2[HttpFoundation][Lock] Ensure compatibility with ext-mongodb v2Oct 21, 2024
'$gt' =>$this->createMongoDateTime(microtime(true)),
],
], [
'readPreference' =>newReadPreference(\defined(ReadPreference::PRIMARY) ? ReadPreference::PRIMARY : ReadPreference::RP_PRIMARY),
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The existing code is incorrect: it checks the existence of the constantvalue. See the conversation why this condition was added:#37140 (comment)

This was removed in 6.4 bybc24cb3#diff-d0f7d4ac57862532ef468d4fa38f1879eeb1c6e6f142118ecfa28dba891601b4L266

@nicolas-grekas
Copy link
Member

Thank you@GromNaN.

@nicolas-grekasnicolas-grekas merged commitb756c5e intosymfony:5.4Oct 22, 2024
11 of 12 checks passed
@GromNaNGromNaN deleted the mongodb-v2 branchOctober 24, 2024 19:54
nicolas-grekas added a commit that referenced this pull requestOct 25, 2024
This PR was merged into the 6.4 branch.Discussion----------[Lock] Ensure compatibility with ext-mongodb v2| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITSame as#58619 for branch 6.4 that was reworked by#52336Commits-------cd3b778 Ensure compatibility with ext-mongodb v2
This was referencedOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@chalasrchalasrchalasr approved these changes

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

+1 more reviewer

@alcaeusalcaeusalcaeus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@GromNaN@carsonbot@nicolas-grekas@alcaeus@OskarStark@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp