Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix linting factories implemented via __callStatic#58618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromKevinVanSonsbeek:bugfix/#58614-method-does-not-exist-for-callStatic-factoryOct 22, 2024
Merged
[DependencyInjection] Fix linting factories implemented via __callStatic#58618
nicolas-grekas merged 1 commit intosymfony:5.4fromKevinVanSonsbeek:bugfix/#58614-method-does-not-exist-for-callStatic-factoryOct 22, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
chalasr approved these changesOct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The patch looks sensible although defining enums as services sounds like a bad idea.
ce67b78 toe2f69afCompare7f548a3 intosymfony:5.4 11 of 12 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedOct 27, 2024
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR is an extension of an old fix made back in#44710.
Factory calls to static methods handled by the
__callStaticmethod currently throw the "Invalid service DYZ: method Class::method() does not exist".