Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] fix encoding issue with UTF-8 addresses containing doubles spaces#58593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4from0xb4lint:issue/mime-utf8-double-spaces
Oct 23, 2024

Conversation

@0xb4lint
Copy link
Contributor

@0xb4lint0xb4lint commentedOct 17, 2024•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58592,Fix#50345
LicenseMIT

@carsonbotcarsonbot added this to the7.2 milestoneOct 17, 2024
@nicolas-grekasnicolas-grekas modified the milestones:7.2,5.4Oct 23, 2024
@nicolas-grekasnicolas-grekas changed the title[Mime] fix encoding issue with UTF-8 addresses containing doubles spaces + tests[Mime] fix encoding issue with UTF-8 addresses containing doubles spacesOct 23, 2024
@symfonysymfony deleted a comment fromcarsonbotOct 23, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but would there be a way to do this in one go in one foreach loop somehow?

@0xb4lint
Copy link
ContributorAuthor

@nicolas-grekas that was my first intention, but I've realized it would result a really messy code (without doing a significant refactor)

performance-wise, I conducted some benchmarks by calling(new MailboxHeader(...))->getBodyAsString()
1M iteration without the second loop: 26.45s - 26.57s
1M iteration with the second loop: 25.47s - 26.14s

@fabpot
Copy link
Member

Thank you@0xb4lint.

@fabpotfabpot merged commitfa18010 intosymfony:5.4Oct 23, 2024
10 of 12 checks passed
This was referencedOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Mime] encoding issue with UTF-8 addresses containing doubles spaces [Mime] Subject: Double space => missing space

4 participants

@0xb4lint@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp