Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Allow auto creation of sqs queue#58575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kevinrudde wants to merge2 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromkevinrudde:fix_42208

Conversation

kevinrudde
Copy link

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#42208
LicenseMIT

I had a look at#44021, which was closed. I implemented the proposed solution inthis comment.

In thesetup function, the code now validates whether the account ID of the current caller identity matches the account ID specified in the DSN. If the IDs match, the queue is created; otherwise, it is not.

valtzu, LangehanebergSven, shyim, and orty17 reacted with rocket emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@kevinruddekevinruddeforce-pushed thefix_42208 branch 3 times, most recently from7d6f13b to4314c00CompareOctober 16, 2024 06:50
@kevinrudde
Copy link
Author

kevinrudde commentedOct 29, 2024•
edited
Loading

Any chance this could land in 7.2?
It seems like the Unit Test is failing, because of some corrupted composer zip?
Edit: Got it working by rebasing!

@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

Messenger Amazon SQS Connection::setup() throws exception when needing to create a queue
3 participants
@kevinrudde@carsonbot@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp