NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[ErrorHandler] Fix patch return type#58549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mtarld wants to merge1 commit intosymfony:7.2frommtarld:fix/ci-patch-return-type

Closed

[ErrorHandler] Fix patch return type#58549

mtarld wants to merge1 commit intosymfony:7.2frommtarld:fix/ci-patch-return-type

Conversation

Copy link

Contributor

mtarld commentedOct 12, 2024•
edited
Loading

Q	A
Branch?	7.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

When trying to patch return types, the following

/** * @return self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT|array<self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT> */publicfunctiongetTargets():string|array{// ...}

becomes

/** * @return self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT|array<self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT> */publicfunctiongetTargets():array{// ...}

becauseself::XXX constants are considered invalid. And therefore only thearray is kept.
But this behavior is wrong, so this PR prevents the return type from changing if a constant is detected.