Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HtmlSanitizer] Fixforce_attributes not replacing existing attribute in initial data#58547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Adding an optional argument is for 7.x
Indeed thanks for the catch! If that's good for you I'll handle it using func_get_args to fix the issue on 6.4 (it's a real bug, I think it's worth it) |
Node is a final class, so it can add the argument directly (as there is no issue regarding keeping BC for child classes overriding the method) |
AppyGG commentedNov 6, 2024
Hi, to help on this issue, is there something to change to allow merge for 6.4 ? |
AppyGG commentedFeb 13, 2025
Hello, small up on this PR, i really think this needs to be fix to improve sanitized content security I'm uncertain if the |
force_attributes not replacing existing attribute in initial data
Fix the override of an existing attribute value.