Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger][Doctrine] Oracle platform, sequences are suffixed with_seq#58529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger][Doctrine] Oracle platform, sequences are suffixed with_seq#58529
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* 6.4: fix merge pass CSV escape characters explicitly move setting deprecation session options into a legacy group test
* 7.1: fix merge pass CSV escape characters explicitly move setting deprecation session options into a legacy group test
…-daubois)This PR was merged into the 7.1 branch.Discussion----------[VarDumper] Fix `DOMCaster` test dumps| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITcc `@xabbuh`Commits-------4201dde [VarDumper] Fix `DOMCaster` test dumps
* 7.1: [VarDumper] Fix `DOMCaster` test dumps
…ies (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[VarDumper] Fix dumping `ext-dom` virtual properties| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITFixes PHP 8.4 CI job.Commits-------273f9cb [VarDumper] Fix dumping `ext-dom` virtual properties
…mpociot)This PR was submitted for the 7.1 branch but it was squashed and merged into the 7.2 branch instead.Discussion----------[Process] Add Laravel Herd php detection path| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? |yes| Deprecations? |no| Issues | –| License | MITAs of right now, using the `PhpExecutableFinder` in combination with Laravel Herd, results in an empty string, which is what this PR fixes.As the PhpExecutableFinder is already aware of XAMPP, it might be a good idea to also add support for Laravel Herd, which is widely used - not only in the Laravel ecosystem.Laravel Herd uses statically compiled PHP binaries, which is why the `PHP_BINDIR` folder always points to `/bin` instead of a user-specific folder.As Laravel Herd adds a `HERD_HOME` environment variable, we can check for the existence of this variable and then add the bin subdirectory to the list of directories to search.I couldn't find any tests for XAMPP, which is why I haven't included any for this addition.Commits-------93ca4e9 [Process] Add Laravel Herd php detection path
…2` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues | -| License | MITFollowingsymfony#58238 (cc `@fancyweb`), for completeness of this 7.2 feature.Commits-------f84170a [Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants
…`, `use_trans_sid`, `trans_sid_hosts` and `trans_sid_tags` options to `NativeSessionStorage`
…iveSessionStorage` (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[HttpFoundation] Deprecate more options in `NativeSessionStorage`| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | yes| Issues | -| License | MITAnother round of deprecations for sessions. RFC for reference:https://wiki.php.net/rfc/deprecate-get-post-sessions#proposalCommits-------60c1aae [HttpFoundation] Deprecate passing `referer_check`, `use_only_cookies`, `use_trans_sid`, `trans_sid_hosts` and `trans_sid_tags` options to `NativeSessionStorage`
…s_per_character` config options
…on to `lint:container` command (ostrolucky)This PR was merged into the 7.2 branch.Discussion----------[FrameworkBundle] Add `--resolve-env-vars` option to `lint:container` command| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? |no| Issues |Fixsymfony#58105| License | MITCommits-------76bab40 [FrameworkBundle] Add --resolve-env-vars option to lint:container command
…` and `session.sid_bits_per_character` config options (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[FrameworkBundle] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | yes| Issues | -| License | MITThese options are (very) likely to be [deprecated in PHP 8.4](https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character). Because of the many reasons of their deprecation, they may be deprecated in Symfony as well starting the next version.Commits-------0d2c231 [FrameworkBundle] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options
* 6.4: [Serializer] Fix for method named `get()` [Notifier][TurboSMS] Process partial accepted response from transport [HttpClient] Fix setting CURLMOPT_MAXCONNECTS throw a meaningful exception when parsing dotenv files with BOM [FrameworkBundle] Fix schema & finish incomplete tests for lock & semaphore config [Cache] Fix RedisSentinel params types [FrameworkBundle] Fix service reset between tests [Uid][Serializer][Validator] Mention RFC 9562 make sure temp files can be cleaned up on Windows
* 6.4: [Process] minor fix [Process] Fix finding executables independently of open_basedir [HttpKernel] Skip logging uncaught exceptions in ErrorHandler, assume $kernel->terminateWithException() will do it parse empty sequence elements as null
* 7.1: [Process] minor fix [Process] Fix finding executables independently of open_basedir [HttpKernel] Skip logging uncaught exceptions in ErrorHandler, assume $kernel->terminateWithException() will do it [Serializer] Fix for method named `get()` [Notifier][TurboSMS] Process partial accepted response from transport parse empty sequence elements as null [HttpClient] Fix setting CURLMOPT_MAXCONNECTS throw a meaningful exception when parsing dotenv files with BOM [FrameworkBundle] Fix schema & finish incomplete tests for lock & semaphore config [Cache] Fix RedisSentinel params types [FrameworkBundle] Fix service reset between tests [Uid][Serializer][Validator] Mention RFC 9562 make sure temp files can be cleaned up on Windows
* 6.4: fix functional tests fix merge fix XSD to allow to configure locks without resources
* 7.1: fix functional tests fix merge fix XSD to allow to configure locks without resources
This PR was merged into the 7.2 branch.Discussion----------[Filesystem] revert test changes| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITwe can revertsymfony#58152 now that the underlying bug was fixed withsymfony#58185Commits-------5ea44be revert test changes
…nnect()` (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[Ldap] Fix deprecated signature call for `ldap_connect()`| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITThe test is using an old signature of `ldap_connect()`. The one-argument signature should always be used.Commits-------9950722 [Ldap] Fix deprecated signature call for `ldap_connect()`
…gets()` (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[Validator] Enhance PHPDoc on `Constraint::getTargets()`| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITProvides better static analysis on constraints.Commits-------5492bf4 [Validator] Enhance PHPDoc on `Constraint::getTargets()`
…sponse has been called
…tResponse when hasResponse has been called (shyim)This PR was submitted for the 5.4 branch but it was squashed and merged into the 7.2 branch instead.Discussion----------[HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MIT```phpif ($event->hasResponse()) { return $event->getResponse();}```PHPStan understands now inside the if that Response is not nullable anymoreCommits-------69f2f48 [HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been calledThis PR was merged into the 7.2 branch.Discussion----------[Lock] Add `NullStore`| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues || License | MITCommits-------dd0721a add NullStore
…iceLoader` class and `choice_lazy` option for `ChoiceType` (yceruto)This PR was merged into the 7.2 branch.Discussion----------[DoctrineBridge][Form] Introducing new `LazyChoiceLoader` class and `choice_lazy` option for `ChoiceType`| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues |symfony#57724| License | MITIt's quite usual to work with forms that process large datasets. In Symfony Form + Doctrine ORM, if you define an `EntityType`, it typically loads all choices/entities fully into memory, and this can lead to serious performance problems if your entity table contain several hundred or thousands of records.The new `LazyChoiceLoader` class addresses this performance issue by implementing an on-demand choice loading strategy. This class is integrated with any `ChoiceType` subtype by using a new boolean option named `choice_lazy`, which activates the feature.Basic usage in a Symfony form looks like this:```php$formBuilder->add('user', EntityType::class, [ 'class' => User::class, // a ton of users... 'choice_lazy' => true,]);```**How does it work?**The loader operates by keeping the choice list empty until values are needed (avoiding unnecessary database queries). When form values are provided or submitted, it retrieves and caches only the necessary choices.As you can see in the code, all this happens behind the `LazyChoiceLoader` class, which delegates the loading of choices to a wrapped `ChoiceLoaderInterface` adapter (in this case, the `DoctrineChoiceLoader`).**Frontend Considerations**Certainly, you may need a JavaScript component for dynamically loading `<select>` options, aka autocomplete plugins. You'll need to develop the endpoint/controller to fetch this data on your own, ensuring it corresponds to the form field data source. This aspect is not included in this project.As a point of reference, the [Autocomplete UX Component](https://symfony.com/bundles/ux-autocomplete/current/index.html) now uses this choice loading strategy, simplifying its autocomplete form type to a single field:<img src="https://symfony.com/doc/bundles/ux-autocomplete/2.x/ux-autocomplete-animation.gif"/>**A Handy Use Case without Javascript?**The `disabled` option renders an `EntityType` form field read-only, and when combined with the `choice_lazy` option, it prevents the loading of unnecessary entities in your choice list (only the pre-selected entities will be loaded), thereby enhancing performance.---Hope this helps to create simpler autocomplete components for Symfony forms.Cheers!Commits-------d73b5ee add LazyChoiceLoader and choice_lazy option
… `When` constraints (KoNekoD)This PR was squashed before being merged into the 7.2 branch.Discussion----------[Validator] Pass context to expressions used in `When` constraints| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues |Fixsymfony#58511| License | MITI encountered a problem with validation of nested entities and I needed to validate by parent field, if draft true then no validation is neededCommits-------f05ce63 [Validator] Pass context to expressions used in `When` constraints
…et (smnandre)This PR was squashed before being merged into the 7.2 branch.Discussion----------[WebProfilerBundle] Render the toolbar stylesheet| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | Fix #...| License | MITRender the (static) toolbar stylesheet separately from the (dynamic) toolbar content.(avoid the 20ko inlined CSS injection on every page)Commits-------c36fcff [WebProfilerBundle] Render the toolbar stylesheet
Messenger auto_setup will create a sequence name based on the table nameand "_seq" suffixed to that name
carsonbot commentedOct 10, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedOct 10, 2024
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "7.2 for features / 5.4, 6.4, and 7.1 for bug fixes". Cheers! Carsonbot |
Messenger auto_setup will create a sequence name based on the table nameand "_seq" suffixed to that name
…ub.com/devloop42/symfony into fix-doctrine-messenger-oracle-seq-name
This PR contains 2541 commits. You should be able to rebase it on |
_seq@alexislefebvre : thanks for your return. I'm going to close this PR and create a new one with a rebase. |
Closing this PR replaced by#58557 |
Uh oh!
There was an error while loading.Please reload this page.
Generated sequences, by doctrine or in this case by the auto_setup of messenger, are suffixed with "_seq".