Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] fix: DoctrineTokenProvider not oracle compatible#58523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jjjb03
Copy link
Contributor

@jjjb03jjjb03 commentedOct 10, 2024•
edited by GromNaN
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issuessee below
LicenseMIT

Problem:
Oracle DB returns all not quoted names in uppercase
(vs. SQLite for example returns non quoted column names as lowercase)

On systems with oracle DB this leads to the Warning/Exception attached below.

see also:PHP Documentation - function.oci-fetch-array- Return Values

Screenshot Warning Access to undefined array key

Oracle converts all not quoted names to uppercase
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@GromNaNGromNaN left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It would be nice to have an integration test for postgres, it was missing in#27314. Not a blocker for this PR.

*/
publicfunctionloadTokenBySeries(string$series)
{
// the alias for lastUsed works around case insensitivity in PostgreSQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was introduced by#27314. The proposed patch also seems to handle postgres issue too.

@carsonbotcarsonbot changed the titlefix: DoctrineTokenProvider not oracle compatible[DoctrineBridge] fix: DoctrineTokenProvider not oracle compatibleOct 10, 2024
Copy link
Member

@GromNaNGromNaN left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change passes the test added by#58528

@fabpot
Copy link
Member

Thank you@jjjb03.

@fabpotfabpot merged commit44fa121 intosymfony:5.4Oct 18, 2024
10 of 12 checks passed
fabpot added a commit that referenced this pull requestOct 18, 2024
…h postgres connection (GromNaN)This PR was merged into the 5.4 branch.Discussion----------[DoctrineBridge] Add integration test for RememberMe with postgres connection| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITRelated to-#27314-#58523Commits-------ca417c0 Add integration test for RememberMe with pg connection
This was referencedOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@GromNaNGromNaNGromNaN approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@jjjb03@carsonbot@fabpot@GromNaN@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp