Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MonologBridge] Fix PHP deprecation withpreg_match()#58492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@simoheinonen
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT
preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated

@carsonbotcarsonbot changed the title[MonologBridge] Fix PHP deprecation with preg_match()Fix PHP deprecation with preg_match()Oct 8, 2024
@carsonbotcarsonbot added this to the5.4 milestoneOct 8, 2024
@carsonbotcarsonbot changed the titleFix PHP deprecation with preg_match()[MonologBridge] Fix PHP deprecation with preg_match()Oct 8, 2024
@xabbuh
Copy link
Member

Can we add a test to prevent regressions?

@alexandre-daubois
Copy link
Member

@xabbuh I don't think so, it is a language-level deprecation so I don't think we can really do anything here?

@stof
Copy link
Member

stof commentedOct 8, 2024

you can write a test running that code without a User-Agent header (i.e. triggering the code path for which you solved the deprecation)

alexandre-daubois, derrabus, OskarStark, simoheinonen, and asrorbekh reacted with thumbs up emoji

@OskarStarkOskarStark changed the title[MonologBridge] Fix PHP deprecation with preg_match()[MonologBridge] Fix PHP deprecation withpreg_match()Oct 8, 2024
@nicolas-grekas
Copy link
Member

Thank you@simoheinonen.

@nicolas-grekasnicolas-grekas merged commitcc3fb70 intosymfony:5.4Oct 9, 2024
11 of 12 checks passed
fabpot added a commit that referenced this pull requestOct 13, 2024
This PR was merged into the 5.4 branch.Discussion----------[MonologBridge] simplify test| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITwe can simplify the test added in#58492 by dropping the custom exception handler as a triggered deprecation would let the test fail anywayCommits-------aa9eb60 simplify test
This was referencedOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@simoheinonen@xabbuh@alexandre-daubois@stof@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp