I'm 👎 here: the length in bytes is what matters. Eg a storage can have a 255-max string field counted in bytes, and this validator guards against longer filenames. Validating in code points makes it really hard to validate any predictable maxlength.

Also, nothing tells this accepts only UTF-8 (it doesn't, bytes are bytes, no encoding expected here).

Hello@nicolas-grekas

For the context of thefilenameMaxLength constraint option, from its name alone, it clearly suggests a validation onthe string's length.

let's take this example :

file-to-upload.pdf (Latin characters)

• character count = 14
• mb_strlen($basename) = 14
• strlen($basename) = 14

файл-завантаження.pdf (non-Latin characters) each character can require 1 to 4 bytes

• character count = 17
• mb_strlen($basename) = 17
• strlen($basename) = 33;

#[Assert\File(
maxSize: '10M',
mimeTypes: ['application/pdf'],
filenameMaxLength: 20,
)]

Result:
Latin characters: passes
Non-Latin characters: fails validation

I find this contradictory 😅.

Hello@OskarStark

ok, I'm waiting for the issue to be validated

We could make this opt-in, eg with a countUnit and a charset option (names taken from the Length constraint)

Thank you@IssamRaouf.