Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
CS: clean some whitespaces/indentation#58472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
keradus commentedOct 6, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix CS |
| License | MIT |
| } | ||
| } | ||
| if ($errors) { | ||
| thrownewInvalidArgumentException(\sprintf('Unable to parse file "%s":',$file).implode("/n",$errors),$e->getCode(),$e); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn’t this have been\n instead?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I honestly have no clue. I would only guess "yes".
I assume there is some test validating result of current behaviour. If you eager to investigate/fix this, please raise it separately.
Unfortunately, I won't be able to check this on my side shortly, and adjust/add missing tests
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OskarStark approved these changesOct 6, 2024
alexandre-daubois approved these changesOct 8, 2024
Member
nicolas-grekas commentedOct 8, 2024
Thank you@keradus. |
b61db2f intosymfony:7.2 4 of 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas added a commit that referenced this pull requestOct 8, 2024
This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Fix newline| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#58472 (comment)| License | MITCommits-------8368669 Fix newline
nicolas-grekas added a commit that referenced this pull requestOct 8, 2024
This PR was squashed before being merged into the 7.2 branch.Discussion----------CS: clean some whitespaces/indentation| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | Fix CS| License | MITCommits-------d0f63b8 CS: clean some whitespaces/indentation
xabbuh added a commit that referenced this pull requestOct 9, 2024
* 5.4: minor#58472 CS: clean some whitespaces/indentation (keradus) Fix newline harden test to not depend on the system's configured default timezone [Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer [ExpressionLanguage] Add missing test case for `Lexer` [FrameworkBundle] Fix passing request_stack to session.listener ensure session storages are opened in tests before destroying them [HttpKernel] Correctly merge `max-age`/`s-maxage` and `Expires` headers [Security][Validator] Check translations for Czech [Security] Fix serialized object representation in tests [DoctrineBridge] Fix risky test warnings
xabbuh added a commit that referenced this pull requestOct 9, 2024
* 6.4: [Form] Remove unnecessary imports minor#58472 CS: clean some whitespaces/indentation (keradus) Fix newline harden test to not depend on the system's configured default timezone [Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer [Doctrine][Messenger] Use common sequence name to get id from Oracle [ExpressionLanguage] Add missing test case for `Lexer` [FrameworkBundle] Fix passing request_stack to session.listener ensure session storages are opened in tests before destroying them [Serializer] Fix `ObjectNormalizer` gives warnings on normalizing with public static property [HttpKernel] Correctly merge `max-age`/`s-maxage` and `Expires` headers [Security][Validator] Check translations for Czech [Security] Fix serialized object representation in tests [DoctrineBridge] Fix risky test warnings [Serializer] Catch `NotNormalizableValueException` for variadic parameters
xabbuh added a commit that referenced this pull requestOct 9, 2024
* 7.1: [Form] Remove unnecessary imports minor#58472 CS: clean some whitespaces/indentation (keradus) Fix newline harden test to not depend on the system's configured default timezone [Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer [Doctrine][Messenger] Use common sequence name to get id from Oracle [ExpressionLanguage] Add missing test case for `Lexer` [FrameworkBundle] Fix passing request_stack to session.listener ensure session storages are opened in tests before destroying them [Serializer] Fix `ObjectNormalizer` gives warnings on normalizing with public static property [HttpKernel] Correctly merge `max-age`/`s-maxage` and `Expires` headers [Security][Validator] Check translations for Czech [Security] Fix serialized object representation in tests [DoctrineBridge] Fix risky test warnings [Serializer] Catch `NotNormalizableValueException` for variadic parameters
symfonyaml pushed a commit to symfonyaml/symfony that referenced this pull requestOct 21, 2024
This PR was squashed before being merged into the 7.2 branch.Discussion----------CS: clean some whitespaces/indentation| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | Fix CS| License | MITCommits-------d0f63b8 CS: clean some whitespaces/indentation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.